Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to Contributors section in README #5298

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix link to Contributors section in README #5298

merged 1 commit into from
Feb 26, 2024

Conversation

BaumiCoder
Copy link
Contributor

The dashes are also part of the link to this section in the GitHub webview and without the link does not work on GitHub. Although, the additional dashes could not fix the link for other editors (e.g. VSCodium with "Markdwn All in One" or an JetBrains IDE).

📑 Summary

Fix one link in the Table of Content from Pull Request from #4961.
The badges in the section header are tricky to handle, while linking to the section. This change fix it atleast for the webview here at GitHub.

📏 Design Decisions

Check the link which GitHub creates automatically for the section (click left from the header of the section) and change it to this version in the markdown file.

📋 Tasks

Make sure you

The dashes are also part of the link to this section in the GitHub
webview and without the link does not work on GitHub.
Although, the additional dashes could not fix the link for other editors
(e.g. VSCodium with "Markdwn All in One" or an JetBrains IDE).
Copy link

netlify bot commented Feb 17, 2024

Deploy Preview for mermaid-js failed.

Name Link
🔨 Latest commit 762113d
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65d0fc41dc37c50008f3a51f

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6be91bc) 43.20% compared to head (762113d) 43.20%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5298   +/-   ##
========================================
  Coverage    43.20%   43.20%           
========================================
  Files           23       23           
  Lines         5115     5115           
  Branches        23       23           
========================================
  Hits          2210     2210           
  Misses        2904     2904           
  Partials         1        1           
Flag Coverage Δ
unit 43.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants