Ignore brew errors

[janelletavares]

Description of change

Acceptance tests failed because we didn't get a coherent response from brew. Printing the upgrade message doesn't seem important enough to fail, so these changes just skip it and exit with no error instead.

Fixes

Type of change

• New feature
• Bug fix
• Refactor
• Documentation

How was this tested?

• Unit Tests
• Tested in staging
• Tested in minikube

Demo

before	after

Additional references

=== RUN TestCollaborationsMySQLToPG/list_resource_types
shared_test.go:164: /app/bin/meroxa --cli-config-file /root/meroxa.main.env resources list --types
shared_test.go:166: TYPES
================
bigquery
elasticsearch
kafka
mongodb
mysql
postgres
redshift
s3
snowflakedb
sqlserver
notion
confluentcloud
panic: runtime error: index out of range [1] with length 0

    goroutine 1 [running]:
    github.com/meroxa/cli/cmd/meroxa/github.parseVersionFromFormulaFile({0x0, 0x0})
    	/build/cli/cmd/meroxa/github/github.go:76 +0x68
    github.com/meroxa/cli/cmd/meroxa/github.GetLatestCLITag({0xe09988?, 0xc000050030?})
    	/build/cli/cmd/meroxa/github/github.go:87 +0x39
    github.com/meroxa/cli/cmd/meroxa/builder.buildCommandAutoUpdate.func1(0xc0004e6000, {0xc000411350?, 0x0?, 0x1?})
    	/build/cli/cmd/meroxa/builder/builder.go:505 +0x1a6
    github.com/spf13/cobra.(*Command).execute(0xc0004e6000, {0xc000034230, 0x1, 0x1})
    	/build/cli/vendor/github.com/spf13/cobra/command.go:923 +0x8c3
    github.com/spf13/cobra.(*Command).ExecuteC(0xc0004be000)
    	/build/cli/vendor/github.com/spf13/cobra/command.go:1044 +0x3bd
    github.com/spf13/cobra.(*Command).Execute(...)
    	/build/cli/vendor/github.com/spf13/cobra/command.go:968
    github.com/spf13/cobra.(*Command).ExecuteContext(...)
    	/build/cli/vendor/github.com/spf13/cobra/command.go:961
    github.com/meroxa/cli/cmd/meroxa/root.Run()
    	/build/cli/cmd/meroxa/root/root.go:52 +0x65
    main.main()
    	/build/cli/cmd/meroxa/main.go:52 +0x253
    
mysql_collaborations_test.go:125: exit status 2

Documentation updated

[raulb]

@janelletavares When I implemented this feature, I added the option to disable these notifications via an environment variable: https://github.com/meroxa/cli/blob/master/cmd/meroxa/builder/autoupdate.go#L33 and opened this other pull-request https://github.com/meroxa/acceptance/commit/413e232c78ed1e08438dc42b211eb57f6aaf69b3

For some reason this is not doing what's supposed to.

I'll take a look.

[raulb]

@janelletavares that should be working. Tested locally and with MEROXA_DISABLE_NOTIFICATIONS_UPDATE=true we shouldn't be checking for latest versions. I'll look into acceptance tests

[raulb]

@janelletavares Did they fail locally or in CI? If it's locally, I'd recommend using MEROXA_DISABLE_NOTIFICATIONS_UPDATE=true or doing meroxa config set DISABLE_NOTIFICATIONS_UPDATE=true

[raulb]

@janelletavares this is a good change to do anyways, but please take a look at my other comments to make sure the other parts are working for you (i.e.: curious wether this failed locally or in our acceptance tests via CI).

[janelletavares]

@janelletavares Did they fail locally or in CI? If it's locally, I'd recommend using MEROXA_DISABLE_NOTIFICATIONS_UPDATE=true or doing meroxa config set DISABLE_NOTIFICATIONS_UPDATE=true

@raulb this failed in an automated acceptance test run in github

[janelletavares]

@janelletavares Did they fail locally or in CI? If it's locally, I'd recommend using MEROXA_DISABLE_NOTIFICATIONS_UPDATE=true or doing meroxa config set DISABLE_NOTIFICATIONS_UPDATE=true

@raulb looks like there's a type in the acceptance tests. the env var should be MEROXA_DISABLE_NOTIFICATIONS_UPDATE, but in the acceptance tests we set MEROXA_DISABLE_UPDATE_NOTIFICATION. update and notification are flipped and notification is singular. I'll open a PR in acceptance repo, too. thanks!

[raulb]

@janelletavares oh no!!! No wonder it wasn't working! Thank you and nice catch!