feat: New --private-key-file flag when creating a resource instance #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janelletavares
requested review from
ericcheatham,
jayjayjpg,
justmisosoup,
nassor and
samirketema
jayjayjpg
approved these changes
Mar 30, 2023
| SSL bool `long:"ssl" short:"" usage:"use SSL"` | ||
| SSHURL string `long:"ssh-url" short:"" usage:"SSH tunneling address"` | ||
| SSHPrivateKey string `long:"ssh-private-key" short:"" usage:"SSH tunneling private key"` | ||
| PrivateKeyFile string `long:"private-key-file" short:"" usage:"path to private key file"` |
There was a problem hiding this comment.
That's neat and as you already said, super helpful with creating snowflake resources in particular!
| @@ -358,3 +366,103 @@ Sign up for the Beta here: https://share.hsforms.com/1Uq6UYoL8Q6eV5QzSiyIQkAc2sm | |||
| t.Fatalf("expected output:\n%s\ngot:\n%s", wantError, gotError) | |||
| } | |||
| } | |||
|
|
|||
| func TestCreateResourceExecutionPrivateKeyFlags(t *testing.T) { | |||
There was a problem hiding this comment.
Nice test coverage as always! ✨
Co-authored-by: Jessy Jordan <jesse@meroxa.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
There are security concerns and UX hiccups around providing the value of a key at the command line rather than the filepath. This adds the file path flag option, and eventually we will deprecate the key value flag.
Also made resource create examples more complete in terms of missing resource types.
Fixes #381
Type of change
How was this tested?
Demo
Additional flag in docs:
Flags: --ca-cert string trusted certificates for verifying resource --client-cert string client certificate for authenticating to the resource --client-key string client private key for authenticating to the resource --env string environment (name or UUID) where resource will be created -h, --help help for create -m, --metadata string resource metadata --password string password --private-key-file string Path to private key file --ssh-private-key string SSH tunneling private key --ssh-url string SSH tunneling address --ssl use SSL --token string API Token --type string resource type (required) -u, --url string resource url --username string usernameAdditional references
Documentation updated