Allow creating a Spire Maritime AIS resource instance without a URL f… #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nassor
reviewed
Mar 31, 2023
| @@ -153,7 +153,9 @@ func (c *Create) Execute(ctx context.Context) error { | |||
| Metadata: nil, | |||
| } | |||
|
|
|||
| if c.flags.Type != string(meroxa.ResourceTypeNotion) && c.flags.URL == "" { | |||
| if (c.flags.Type != string(meroxa.ResourceTypeNotion) && | |||
| c.flags.Type != string(meroxa.ResourceTypeSpireMaritimeAIS)) && | |||
There was a problem hiding this comment.
Can a unit test case be added for that?
nassor
approved these changes
Apr 3, 2023
janelletavares
force-pushed
the
spire-maritime-ais
branch
from
d92b67d
to
f75f666
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lag value
Description of change
URL is hardcoded for this resource type
Fixes #671
Type of change
How was this tested?
Demo
Additional references
Documentation updated