Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure label exist and is string in resource types #673

Merged
merged 1 commit into from Apr 3, 2023
Merged

Ensure label exist and is string in resource types #673

merged 1 commit into from Apr 3, 2023

Conversation

lyuboxa
Copy link
Contributor

@lyuboxa lyuboxa commented Apr 1, 2023 •
edited

Description of change

When the label is wrong, it will render %!s(<nil>) .

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Demo

before after

Additional references

Documentation updated

@lyuboxa lyuboxa self-assigned this Apr 1, 2023
@janelletavares
Copy link
Contributor

Thanks!

@lyuboxa lyuboxa merged commit ed6e780 into master Apr 3, 2023
5 checks passed
@lyuboxa lyuboxa deleted the lk/fix-resource-type-parse branch April 3, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janelletavares janelletavares janelletavares approved these changes

Assignees

@lyuboxa lyuboxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lyuboxa @janelletavares