Skip to content

Commit

Permalink
Add TryCatchUpWithPrimary to StackableDB (facebook#5855)
Browse files Browse the repository at this point in the history
Summary:
as title.

Test Plan (on devserver):
```
$make all && make check
```
Pull Request resolved: facebook#5855

Differential Revision: D17615125

Pulled By: riversand963

fbshipit-source-id: bd6ed8cf59eafff41f0d1fc044f39e8f3573172a
  • Loading branch information
riversand963 authored and facebook-github-bot committed Sep 27, 2019
1 parent 864b26c commit 9b92786
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions HISTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
* The MemTable Bloom filter, when enabled, now always uses cache locality. Options::bloom_locality now only affects the PlainTable SST format.
* Deprecate `snap_refresh_nanos` option.
* Added DisableManualCompaction/EnableManualCompaction to stop and resume manual compaction.
* Add TryCatchUpWithPrimary() to StackableDB in non-LITE mode.
### Performance Improvements
* Improve the speed of the MemTable Bloom filter, reducing the write overhead of enabling it by 1/3 to 1/2, with similar benefit to read performance.

Expand Down
6 changes: 6 additions & 0 deletions include/rocksdb/utilities/stackable_db.h
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,12 @@ class StackableDB : public DB {
return db_->DefaultColumnFamily();
}

#ifndef ROCKSDB_LITE
Status TryCatchUpWithPrimary() override {
return db_->TryCatchUpWithPrimary();
}
#endif // ROCKSDB_LITE

protected:
DB* db_;
std::shared_ptr<DB> shared_db_ptr_;
Expand Down

0 comments on commit 9b92786

Please sign in to comment.