Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enclosed change should resolve #337. It seems that ifort represent logical true using 255 rather than 1. As a result, when we pass the "is_oshell" flag value from Fortran to C code (https://github.com/merzlab/QUICK/blob/master/src/cuda/gpu.cu#L385-L402), the value in C code was not set properly, and closed shell kernel was invoked for open shell XC calculation (https://github.com/merzlab/QUICK/blob/master/src/cuda/gpu_getxc.cu#L98-L113). Please test and merge.