Use non-arrow-function for export #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @quentinvernot, thank you for the pull request.
Yes, you can push that here too. 👍 |
In strict mode, the elements in `arguments` are not the same ref as the actual arguments used in the function, editing one won't change the other. [Useful MDN link](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode#Making_eval_and_arguments_simpler)
|
Done, took a bit of time to confirm it worked. |
mesaugat
approved these changes
Nov 30, 2018
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a tiny fix to allow the lib to run in IE11 (did it via karma).
I also found a similar problem when attempting to babelify the code as babel adds a
"use strict"to the module, which breaksassertEqualbecauseargumentsbehaves slightly differently in strict mode. It's also an easy fix, should I do that while I'm at it?