Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break internal dependencies in service #437

Closed
antho1404 opened this issue Sep 7, 2018 · 1 comment · Fixed by #491
Closed

Break internal dependencies in service #437

antho1404 opened this issue Sep 7, 2018 · 1 comment · Fixed by #491
Labels
refactoring

Comments

@antho1404
Copy link
Member

Event, Outputs etc... have a reference on the service and the only reason they have this is to have a nice error message. The service is never needed in the actual business logic, it's just user cosmetic so I would recommend to get rid of this because it's not really needed for the business logic and it can make things complicated in the future

related PR #417 (review)
@ilgooz
Copy link
Contributor

ilgooz commented Sep 21, 2018

#475 includes this

@ilgooz ilgooz mentioned this issue Sep 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

service: reduce cycling refs mesg-foundation/engine
2 participants
@antho1404 @ilgooz