Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of cycling references in service package #475

Closed
ilgooz opened this issue Sep 18, 2018 · 0 comments
Closed

get rid of cycling references in service package #475

ilgooz opened this issue Sep 18, 2018 · 0 comments
Assignees
@ilgooz
Labels
enhancement New feature or request

Comments

@ilgooz
Copy link
Contributor

ilgooz commented Sep 18, 2018

instead of making cycling references to carry Service around, we can create a dummy service struct to keep Service data or keep the same Service but by dereferencing it or one another option is to only carry necessary fields like ServiceName.
@ilgooz ilgooz added the enhancement New feature or request label Sep 18, 2018
@ilgooz ilgooz self-assigned this Sep 18, 2018
This was referenced Sep 18, 2018
Merged
Closed
ilgooz added a commit that referenced this issue Sep 24, 2018
@ilgooz
service: reduce cycling references, related with #475
487beb3
ilgooz added a commit that referenced this issue Sep 24, 2018
@ilgooz
service: reduce cycling references, related with #475
c7fed71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilgooz ilgooz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krhubert @ilgooz