introduce Newable service #417
Conversation
ilgooz
force-pushed
the
feature/service-new
branch
5 times, most recently
from
ee1072f
to
8184f7c
Compare
|
prevent cycling references if possible /cc @antho1404 |
ilgooz
force-pushed
the
feature/service-new
branch
7 times, most recently
from
15ff4c3
to
08ddceb
Compare
* use slices instead maps on Service type, closes #394. * use slices instead maps on service.proto. * add ServiceDefinition type to service/importer. * rm unneeded fields in service.proto in interface/grpc/core. * rm unneeded service.DependenciesFromService(), closes #393. * rm unneeded TestDependenciesFromService test in service/. * rm unneeded TestSaveReturningHash test in database/services. * rm unneeded TestInjectConfigurationInDependencies test in api/, TestNew test in service/ covers it. * move TestInjectConfigurationInDependenciesWithConfig test as TestInjectDefinitionWithConfig from api/ to service/. * move TestInjectConfigurationInDependenciesWithDependency test as TestInjectDefinitionWithDependency from api/ to service/. * rm unneeded TestInjectConfigurationInDependenciesWithDependencyOverride test in api/. * use getters in service package for other needed places. * rm unnecessary nil checks. * cleanup service package. * minor improvements.
ilgooz
force-pushed
the
feature/service-new
branch
from
08ddceb
to
2be114d
Compare
ilgooz
force-pushed
the
feature/service-new
branch
from
869f4ec
to
ff7ca9f
Compare
There was a problem hiding this comment.
We don't need to implement this now, these are mostly notes but nothing blocking for the merge
Too many services
In many places we need to do a service.FromService(&service.Service{}). It's not really clear, I recommend to use Definition service.FromDefinition(&service.Definition{})
Same with the fromService() => fromDefinition()
Reminder
We will need to update the Go and JS library
Service in sub-structs
Event, Outputs etc... have a reference on the service and the only reason they have this is to have a nice error message. The service is never needed in the actual business logic, it's just user cosmetic so I would recommend to get rid of this because it's not really needed for the business logic and it can make things complicated in the future
|
after some investigation we realized that problem with the service list command was due to a leftover mesg-core docker volume that has some services with the old version of Service definition. everything is fine after volume is destroyed. |
This reverts commit 9f89621.
… status info on service list cmd
|
good to review |
depends on #414.