Update keep alive of client to 5min to prevent spamming the server #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasMahe
added
bug
This was referenced Feb 5, 2019
Closed
ilgooz
previously approved these changes
Feb 5, 2019
|
This fix worked for me |
ilgooz
approved these changes
Feb 5, 2019
krhubert
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #760, #759 and #770
Client should not ping the server more often than the
EnforcementPolicy.MinTimeset on the server otherwise they get a GOAWAY error.By default it's 5min, so I set the client to ping the server every 5min.
Also, by setting the client ping > to server ping, it also resolves the problem when both client and server were pigging themselve in both way. Now the client actually never has to ping the server if the connection is still open and the server pings the client.
This is a critical fix and needs to be released as soon as possible.