Add unit tests for Slack integration #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to test the Slack integration without having to resort to Jest's module-mocking.
This should ensure that all anyone who runs the tests uses the same TZ, which will prevent test flakiness due to system time zone collision.
nuyawktuah
added a commit
that referenced
this pull request
Dec 20, 2020
* WIP * WIP * Formatter * Reorder * WIP * WIP * WIP * Add apartment and slack_ts * Add slack api, upgrade pg * Fix cert issue * Update dependencies * Better messages * Log id * Formatter * Add success_url and failure_url * Allow unauthorized * Update acuity webhook * Return devices object * Ignore intersections with start or end building * Use slack api * Update nodes kml * Add apartment, formatting * Fix devices * Add unit tests for Slack integration (#54) * Add dependency on Jest for unit testing * Add unit tests for Slack integration * Use dependency injection for Slack client This will make it easier to test the Slack integration without having to resort to Jest's module-mocking. * Remove unnecessary exports from Slack module * Simplify unit-testing strategy for Slack module * Finish unit tests for Slack module * Run tests in UTC time zone This should ensure that all anyone who runs the tests uses the same TZ, which will prevent test flakiness due to system time zone collision. * A bunch of changes Co-authored-by: olivermesh <oliver@meshcenter.org> Co-authored-by: greenberga <38597857+greenberga@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.