-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quality sharpness #126
Comments
Have you tried Meshenger 4.2.4? And have you tried changing the resolution via the menu (small gear icon in the left top corner) during a call? |
Yeah, I don't know if it's my phone's camera, but I changed it to capture and cast, and it's blurry, even though I set resolution first |
Then it is hard to say why WebRTC cannot or won't capture a higher quality video stream. |
I switched to h264 encoding and the sharpness improved a lot, but the latency issues remained |
hm, where did you switch it to h264? |
I customized the encoderFactory, which uses vp8 by default, and I changed it to h264 |
Please share you changes. Maybe it is enough to expose the vp8 and h264 setting. Then I could add those as settings. |
Nice. Have you tried to just disable VP8? https://github.com/meshenger-app/meshenger-android/blob/master/app/src/main/kotlin/d/d/meshenger/call/RTCCall.kt#L531 (with enabled hardware accelaration) |
Thank you. I will give it a try. |
I looked at your commit history, it seems that you did not set up a custom factory, just configured the default acceleration factory, I will provide my coding factory class for you to see |
@CWTakiku thank you, I will give it a try. I did not commit my custom factory, since it broke the call feature for me. |
I tried the code with only isSupportedH264 returning true (like in your screenshot), but now the phones cannot establish a connection. Aside from that, the picture quality with the current master is pretty good (HD). |
What you need is that both the receiver and the sender need to set up the custom encoder to establish the connection, and how does your image quality improve |
hm, I had the same software on both devices. Here is the source code: https://github.com/meshenger-app/meshenger-android/tree/h264 |
I will do an intermediate release with enabled hardware decoding by default (it wasn't working right before). Then let's do more testing. |
Ok, theoretically it's OK, but it's been proven to work on my side and has been used in my own projects |
Let's close this issue. It seem to be resolved. But the CPU overuse detection might still ruin the day. But it can be disabled in the setting on the users own risk. |
How to improve clear picture quality, adjustment does not seem to work
The text was updated successfully, but these errors were encountered: