new structure with smi and install commands #71
Conversation
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
|
@mgfeller @kushthedude It would be great if we can discuss on the new structure and the principles that needs to be defined to follow them throughout the adaptor repositories. |
scripts/smi/smi.yaml
Outdated
| @@ -0,0 +1,86 @@ | |||
| --- | |||
There was a problem hiding this comment.
Can this be centrally defined and imported from the Learn Layer5 repo?
There was a problem hiding this comment.
Yes right, let me craete a helm chart for this, so that we can version them too.
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
| @@ -13,5 +13,5 @@ var ( | |||
|
|
|||
| // ErrViper is the error object for viper | |||
| func ErrViper(err error) error { | |||
| return errors.New("701", fmt.Sprintf("Viper initialization failed with error: %s", err.Error())) | |||
There was a problem hiding this comment.
These error codes need to be centrally defined, not per repo, assuming that's what's happening here.
|
Thank you for today’s demo, @kumarabd. Before merging, will you attend to each of the failed build checks? |
scripts/smi/delete.sh
Outdated
| set -e | ||
|
|
||
| if ! type "kubectl" > /dev/null 2>&1; then | ||
| printf "ERROR\tgrep cannot be found\n" |
scripts/smi/smi.yaml
Outdated
| cpu: "200m" | ||
| memory: 500Mi | ||
| restartPolicy: Always | ||
| serviceAccount: meshery |
There was a problem hiding this comment.
serviceAccount is deprecated I just learned from my IDE
scripts/smi/deploy.sh
Outdated
| set -e | ||
|
|
||
| if ! type "kubectl" > /dev/null 2>&1; then | ||
| printf "ERROR\tgrep cannot be found\n" |
|
Hi @kumarabd, great demo today! I'm still familiarizing myself with the code, it looks good and I learn a lot :-) I also ran the adapter locally (microk8s). |
internal/config/defaults.go
Outdated
| @@ -24,24 +23,31 @@ var ( | |||
|
|
|||
| // operations holds the supported operations inside mesh | |||
| operations = map[string]interface{}{ | |||
| installKuma: map[string]interface{}{ | |||
| "type": "INSTALL", | |||
| InstallKuma: map[string]interface{}{ | |||
There was a problem hiding this comment.
Do adapter operations belong in a defaults file?
There was a problem hiding this comment.
@leecalcote Its either inject the config, or have it remained as a default. Injecting would mean that u do it via the main.go file. Do we want to have another hop for this?
There was a problem hiding this comment.
Renaming this file to supported_operations.go will probably suffice.
There was a problem hiding this comment.
out of curiosity, do we have unsupported operations?
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
|
@kumarabd a few conflicts to resolve here - https://github.com/layer5io/meshery-kuma/pull/71/conflicts |
|
@kumarabd good to merge after resolving conflicts. Let's release v0.2.0 after merge. |
@leecalcote Lets move with this first - #75 so that @shivaylamba can move ahead with his task. We can merge this PR along with the our meshkit decision. Sounds good? |
|
Sounds real good, @kumarabd 👍 |
Signed-off-by: kumarabd abishekkumar92@gmail.com