Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading test_adapter to v2 for all e2e centralized tests #234

Merged
merged 1 commit into from
May 21, 2023

Conversation

yash37158
Copy link
Member

Description
This PR migrates the adapter to v2 for all centralized e2e tests
This PR fixes #233

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: yash37158 <yash37158@gmail.com>
@welcome
Copy link

welcome bot commented May 17, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@yash37158
Copy link
Member Author

yash37158 commented May 17, 2023

Hey @leecalcote @Revolyssup @Chadha93, can you please review the pr

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@leecalcote
Copy link
Member

Build checks running…

@acald-creator acald-creator merged commit 121a226 into meshery:master May 21, 2023
@welcome
Copy link

welcome bot commented May 21, 2023

Thanks for your contribution to the Layer5 community! 🎉

Congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need for upgrading test adapter to v2 for all e2e tests
3 participants