Kalradev/feature/meshsync #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 12, 2020 14:12
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
… clients Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
added 2 commits
November 12, 2020 18:32
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
leecalcote
approved these changes
Nov 12, 2020
leecalcote
reviewed
Nov 12, 2020
| }, nil | ||
| } | ||
|
|
||
| // ListVirtualService will list virtual service for given namespaces |
There was a problem hiding this comment.
These Istio-specific functions are disconcerting.
There was a problem hiding this comment.
But understandably necessary.
|
Very pleased to see this coming through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #
Notes for Reviewers
Implemented discovery mechanisms for virtual service discovery
Signed commits