-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kalradev/feature/meshsync #41
Kalradev/feature/meshsync #41
Conversation
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
… clients Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generic Kubernetes discovery is great. The service mesh specifics are ideally coming from the adapters.
I understand that we're using the Istio client go and so we must write Istio-specifics into a pipeline dedicated to Istio.
}, nil | ||
} | ||
|
||
// ListVirtualService will list virtual service for given namespaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These Istio-specific functions are disconcerting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But understandably necessary.
Very pleased to see this coming through. |
Description
This PR fixes #
Notes for Reviewers
Implemented discovery mechanisms for virtual service discovery
Signed commits