Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kalradev/meshsync/istio #43

Merged

Conversation

0xfirefist
Copy link
Contributor

Description

Notes for Reviewers
Implemented code for istio specific resource discovery

Signed commits

  • Yes, I signed my commits.

Dev Kalra added 5 commits November 17, 2020 14:46
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Copy link
Contributor

@kumarabd kumarabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumarabd kumarabd merged commit fed8539 into meshery:kumarabd/feature/meshsync Nov 18, 2020
@0xfirefist 0xfirefist deleted the kalradev/meshsync/istio branch November 18, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants