Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new Meshery logo and tagline have been added to the README.md file. #520

Merged

Conversation

rj2704
Copy link
Contributor

@rj2704 rj2704 commented Sep 14, 2023

Description

This PR fixes #510

Signed-off-by : jigarrathod2704@gmail.com

Notes for Reviewers
The new Meshery logo and tagline have been added to the README.md file.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Jigar Rathod <jigarrathod2704@gmail.com>
@welcome
Copy link

welcome bot commented Sep 14, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8fac00e) 50.22% compared to head (ffcf025) 50.22%.
Report is 8 commits behind head on master.

❗ Current head ffcf025 differs from pull request most recent head a456f8d. Consider uploading reports for the commit a456f8d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #520   +/-   ##
=======================================
  Coverage   50.22%   50.22%           
=======================================
  Files           9        9           
  Lines         450      450           
=======================================
  Hits          226      226           
  Misses        209      209           
  Partials       15       15           
Flag Coverage Δ
unittests 50.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leecalcote leecalcote added the area/docs Improvements or additions to documentation label Sep 27, 2023
@Aisuko Aisuko self-requested a review October 6, 2023 05:19
README.md Outdated Show resolved Hide resolved
Signed-off-by: Aisuko <urakiny@gmail.com>
@Aisuko Aisuko self-requested a review October 6, 2023 05:26
Copy link
Member

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aisuko Aisuko merged commit d696810 into meshery:master Oct 6, 2023
2 checks passed
@welcome
Copy link

welcome bot commented Oct 6, 2023

        Thank you for contributing to the Layer5 community! 🎉 \ \ Meshery Logo \ \         ⭐ Please leave a star on the project. 😄

@Aisuko
Copy link
Member

Aisuko commented Oct 6, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] readme: use Meshery logo with tagline
3 participants