Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integrations UI] Add remaining meshery integrations #1005

Closed
Shivam-AfA opened this issue Feb 6, 2023 · 11 comments
Closed

[Integrations UI] Add remaining meshery integrations #1005

Shivam-AfA opened this issue Feb 6, 2023 · 11 comments
Labels
area/ci Continuous integration | Build and release area/website component/ui User Interface help wanted Extra attention is needed issue/stale Issue has not had any activity for an extended period of time kind/bug Something isn't working kind/enhancement New feature or request

Comments

@Shivam-AfA
Copy link
Contributor

Shivam-AfA commented Feb 6, 2023

Description

https://meshery.io/ website features only 80 integrations in contrast to the 150 integrations on the https://layer5.io/ website.

Expected Behavior

All the remaining integrations need to be added to the integrations section on meshery.io website.

How to Implement

See #1005 (comment)

Screenshots

Meshery.io website
image

Layer5 wesbite
image

Enviroment:

  • OS: Mac Linux Windows
  • Browser: Chrome Safari Firefox
  • Version:
  • Device: Desktop Mobile

Contributor Guides and Handbook

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

@Shivam-AfA Shivam-AfA added kind/bug Something isn't working kind/enhancement New feature or request component/ui User Interface area/website labels Feb 6, 2023
@welcome
Copy link

welcome bot commented Feb 6, 2023

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Meshery Contributors' Welcome Guide and sure to join the community Slack.

@Shivam-AfA Shivam-AfA changed the title [Integrations] Add remaining meshery integrations [Integrations UI] Add remaining meshery integrations Feb 6, 2023
@leecalcote leecalcote added area/ci Continuous integration | Build and release help wanted Extra attention is needed labels Feb 6, 2023
@Savio629
Copy link
Contributor

Savio629 commented Feb 7, 2023

@Shivam-AfA So remaining 70 integrations should be added to meshery.io website?
I can take up the issue....

@leecalcote
Copy link
Member

leecalcote commented Feb 7, 2023

@Savio629, thanks for raising your hand. To clarify, this needs to be done programmatically (and not by manually adding the integrations. The solution here has to do with GitHub Workflow logic. @asubedy will you investigate?

@Savio629
Copy link
Contributor

Savio629 commented Feb 8, 2023

Yeah it seems I just thought that I would have to copy the 70 integrations from layer5.io and add them in meshery.io. Sorry for directly hoping in, instead of exploring the issue a bit more from my side.

@gopivaibhav
Copy link
Contributor

I am interested to work on this issue and I have gone through this issue in the CI call. So, can I get assigned to it?

@Shivam-AfA
Copy link
Contributor Author

Sure @gopivaibhav. Do consider this:

this needs to be done programmatically (and not by manually adding the integrations. The solution here has to do with GitHub Workflow logic.

@asubedy
Copy link
Member

asubedy commented Feb 9, 2023

Ok, these are where the issue present

  1. The workflow integration_updater is working perfectly fine, it updates the layer5 repo as well as meshery repo with the required files or changes.
  2. In the Meshery repository the workflow makes changes to the data.json file and then commits it. And this file has the correct number of integrations, that is around 150.
  3. So now the problem here is that the current html file that is responsible for showing the integration integration.html is using a the data source as a different js file as seen here. This file data.js has hardcoded 80 integrations hence we see only 80 integrations on the website
  4. So if we use the content from data.json file to show the integrations then this should solve the problem.

Few things to take note:
The content on data.json file is in such format

[{
      "name":"Fluid",
      "color":"../images/integration/fluid-color.svg",
      "white":"../images/integration/fluid-white.svg"},....]

So to render the integrations properly first the inverted commas on the keys that are "name","color" and "white" should be removed and the image link should not have the integration part so the image link will look like ../images/fluid-color.svg

@Shivam-AfA
Copy link
Contributor Author

@gopivaibhav any updates on this?

@gopivaibhav
Copy link
Contributor

@gopivaibhav any updates on this?

The issue is almost done but I guess I need to change the styling as I can't see all the 150 integrations without scrolling in the table format. Please do let me know if this is fine or I will try to change the styling of the page.

@stale
Copy link

stale bot commented Apr 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 17, 2023
@stale
Copy link

stale bot commented Apr 25, 2023

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release area/website component/ui User Interface help wanted Extra attention is needed issue/stale Issue has not had any activity for an extended period of time kind/bug Something isn't working kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants