Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CSS on Page : meshery.io/blog #936

Merged
merged 4 commits into from
Jan 2, 2023
Merged

Updated CSS on Page : meshery.io/blog #936

merged 4 commits into from
Jan 2, 2023

Conversation

UtkarshMishra12
Copy link
Member

@UtkarshMishra12 UtkarshMishra12 commented Dec 16, 2022

Signed-off-by: Utkarsh Mishra nasautkarsh@gmail.com

Description
Updated CSS on Page: meshery.io/blog

This PR fixes #

Notes for Reviewers
Before:
image

Now:
image

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Utkarsh Mishra <nasautkarsh@gmail.com>
@netlify
Copy link

netlify bot commented Dec 16, 2022

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 3ad7532
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/63b33180972e0d0008c2b2c2
😎 Deploy Preview https://deploy-preview-936--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@GaganpreetKaurKalsi GaganpreetKaurKalsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we replace the image as well with the one we use on layer5, @leecalcote.

image

@eeshaanSA
Copy link
Contributor

@GaganpreetKaurKalsi, shouldn't the image shrink for the mobile view? Looks way too big.
image

@GaganpreetKaurKalsi
Copy link
Contributor

@GaganpreetKaurKalsi, shouldn't the image shrink for the mobile view? Looks way too big. image

Correct, need to size the image according to mobile as well.

@eeshaanSA
Copy link
Contributor

@UtkarshMishra12

@leecalcote
Copy link
Member

Great feedback.

@GaganpreetKaurKalsi
Copy link
Contributor

Any updates @UtkarshMishra12?

@leecalcote
Copy link
Member

@UtkarshMishra12 I've put this item as a point of discussion for tomorrow's meeting.

Signed-off-by: Utkarsh Mishra <nasautkarsh@gmail.com>
@UtkarshMishra12
Copy link
Member Author

Now: @leecalcote

Blog._.Meshery.-.Google.Chrome.2023-01-03.01-01-45.mp4

@leecalcote leecalcote merged commit 73421bc into meshery:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants