Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Navigation highlight not working properly for subsections under Management section #3268

Closed
humblenginr opened this issue Jun 25, 2021 · 7 comments · Fixed by #3271
Closed
Assignees
Labels
component/ui User Interface first-timers-only Please contribute! All are welcome. framework/react issue/stale Issue has not had any activity for an extended period of time kind/bug Something isn't working

Comments

@humblenginr
Copy link
Member

humblenginr commented Jun 25, 2021

Description

Subsections under Management section are not getting highlighted when navigated to those sections. But rather, Management is getting highlighted

Expected Behavior

The navigated subsection should be highlighted.

Screenshots/Logs

Screen.Recording.2021-06-25.at.10.46.17.AM.mov

Environment:

  • Meshery Version: stable-v0.5.26
  • Kubernetes Version: v1.19.7
  • Host OS: Big Sur
  • Browser: Brave

Contributor Resources:

@humblenginr humblenginr added kind/bug Something isn't working component/ui User Interface framework/react labels Jun 25, 2021
@welcome
Copy link

welcome bot commented Jun 25, 2021

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.

@github-actions
Copy link

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@humblenginr humblenginr changed the title [UI] Navigation highlight not working properly for subsections under **Management** section [UI] Navigation highlight not working properly for subsections under Management section Jun 25, 2021
@humblenginr humblenginr added the first-timers-only Please contribute! All are welcome. label Jun 25, 2021
@nishit-prasad
Copy link
Contributor

Hello, I am a newcomer to open source contributions and would like to work on this.

Currently reviewing the documentation/guidelines and setting up my environment.
I have joined the Layer5 Slack workspace.

Thanks!

@humblenginr
Copy link
Member Author

humblenginr commented Jun 25, 2021

Welcome @nishit-prasad 🥳 , there are a lot of people in the community willing to help people. Just ping on slack if you face any difficulties ✌🏽

Happy contributing !

@nishit-prasad
Copy link
Contributor

Thank you! I really appreciate it!

@stale
Copy link

stale bot commented Aug 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Aug 4, 2021
@stale
Copy link

stale bot commented Aug 14, 2021

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed Aug 14, 2021
humblenginr added a commit to nishit-prasad/meshery that referenced this issue Aug 30, 2021
humblenginr added a commit that referenced this issue Aug 30, 2021
[<Navigator/>]: Navigation highlight fix on subsections under Management section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface first-timers-only Please contribute! All are welcome. framework/react issue/stale Issue has not had any activity for an extended period of time kind/bug Something isn't working
Projects
None yet
2 participants