[Docs] Relationships: Grammar fix in the "Design Relationships and Restrictions" section #10003
Conversation
Signed-off-by: neerajmanivarnan <neerajmanivarnan666@gmail.com>
Signed-off-by: neerajmanivarnan <neerajmanivarnan666@gmail.com>
|
🚀 Preview for commit 86ecf9a at: https://65a82e4649068a008769b8fc--meshery-docs-preview.netlify.app |
| @@ -50,7 +52,7 @@ This command enable users to import their existing applications from sources as | |||
|
|
|||
| **Step 1: Access the Meshery UI** | |||
|
|
|||
| To import a Docker Compose app into Meshery using the Meshery UI, you must first [install Meshery](../installation/quick-start.md) | |||
| To import a Docker Compose app into Meshery using the Meshery UI, you must first [install Meshery](/installation/quick-start) | |||
There was a problem hiding this comment.
Why are there changes here -- commits from another issue perhaps(?), this isn't part of the issue description/request.
There was a problem hiding this comment.
Those are commits from the issue #9991
There was a problem hiding this comment.
Thanks for this review, @sandramsc 👏
There was a problem hiding this comment.
@neerajmanivarnan, don't include commits from a separate PR into another PR.
|
Please consider updating the heading of the PR to be more closely worded with the related issue, it makes for a more efficient review for contributors and maintainers. i.e Repeating the issue title --> [Fix Docs Designs] Misplaced full stop |
|
@neerajmanivarnan send word when you've incorporated @sandramsc's feedback> |
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
@neerajmanivarnan here PR renaming feedback takes all of 4 seconds to update... |
leecalcote
changed the title
| @@ -6,6 +6,8 @@ permalink: guides/configuration-management/importing-apps | |||
| category: configuration | |||
| type: guides | |||
| language: en | |||
| redirect_from: | |||
| - /installation/quick-start.md | |||
There was a problem hiding this comment.
No. This is not only inaccurate, but improper syntax.
docs/pages/guides/configuration-management/importing-applications.md
Outdated
Show resolved
Hide resolved
…ons.md Signed-off-by: Lee Calcote <leecalcote@gmail.com>
|
Thanks for your contribution to Meshery! 🎉
|
|
Thanks for contributing, @neerajmanivarnan 👍 |
|
Whoo-hoo! A first PR!! Congrats, @neerajmanivarnan 🎈 |
Notes for Reviewers
This PR fixes the misplaced full stop issue referred by #9997
This PR fixes #9997
Signed commits