Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Relationships: Grammar fix in the "Design Relationships and Restrictions" section #10003

Merged
merged 5 commits into from
Jan 21, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/pages/concepts/logical/designs.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ language: en
list: include
---

Like a Google Doc, Designs are your primary tool for collaborative authorship of your infrastructure and services. A Design describes All the resources and their properties that you want for a single deployment written inAll the resources and their properties that you want for a single deployment written in YAML based on Meshery's declarative syntax (see [Meshery Schemas repo]((https://github.com/meshery/schemas)). By default, Designs are stored in your user account, but can be manually exported, programmatically snapshotted, or automatically synchronized to any OCI-compatible registry (e.g. Docker Hub, AWS ECR, and so on), or Git-based repositories (coming in v0.8). You can share designs and collaborate in real-time on their creation. Designs can be imported, exported, versioned, forked, merged, snapshotted, published, shared, embedded, templatized, and more.
Like a Google Doc, Designs are your primary tool for collaborative authorship of your infrastructure and services. A Design describes All the resources and their properties that you want for a single deployment written inAll the resources and their properties that you want for a single deployment written in YAML based on Meshery's declarative syntax (see [Meshery Schemas repo](<(https://github.com/meshery/schemas)>). By default, Designs are stored in your user account, but can be manually exported, programmatically snapshotted, or automatically synchronized to any OCI-compatible registry (e.g. Docker Hub, AWS ECR, and so on), or Git-based repositories (coming in v0.8). You can share designs and collaborate in real-time on their creation. Designs can be imported, exported, versioned, forked, merged, snapshotted, published, shared, embedded, templatized, and more.

<!-- ### Using Designs -->

Expand All @@ -27,7 +27,7 @@ There cannot be two components with the same name within a Design. However, ther
- Designs can be snapshotted. Snapshots are immutable. Snapshots can be compared for differences between Design versions.
- Snapshots can be exported or embedded.
- Designs can be embedded.
- Designs can be converted into reusable Patterns. Creating a Pattern. involves replacing the values of the variables in the design with the values provided by another user.
- Designs can be converted into reusable Patterns. Creating a Pattern involves replacing the values of the variables in the design with the values provided by another user.
- The user who creates a Pattern is called the **pattern owner**.
- Designs can be deployed. Deploying a Design involves incorporating one or more components into your Design, configuring their relationships, and deploying them to one or more Environments. By default, any user of a Workspace can deploy a Design.
- Designs can be deleted.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ permalink: guides/configuration-management/importing-apps
category: configuration
type: guides
language: en
redirect_from:
- /installation/quick-start.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. This is not only inaccurate, but improper syntax.

leecalcote marked this conversation as resolved.
Show resolved Hide resolved
---

Import your existing application definitions and your existing infrastructure configruations into Meshery
Expand Down Expand Up @@ -50,7 +52,7 @@ This command enable users to import their existing applications from sources as

**Step 1: Access the Meshery UI**

To import a Docker Compose app into Meshery using the Meshery UI, you must first [install Meshery](../installation/quick-start.md)
To import a Docker Compose app into Meshery using the Meshery UI, you must first [install Meshery](/installation/quick-start)
Copy link
Member

@sandramsc sandramsc Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there changes here -- commits from another issue perhaps(?), this isn't part of the issue description/request.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are commits from the issue #9991

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this review, @sandramsc 👏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neerajmanivarnan, don't include commits from a separate PR into another PR.


**Step 2: Navigate to the Application section in the Configuration**

Expand All @@ -67,3 +69,4 @@ When you import an app into Meshery, it will create a Meshery App based on defin
<a href="{{ site.baseurl }}/assets/img/applications/ImportApp.png"><img alt="Import-Application" style="width:500px;height:auto;" src="{{ site.baseurl }}/assets/img/applications/ImportApp.png" /></a>

Once the Meshery App has been created, you can use Meshery to manage, operate and observe your cloud native infrastructure. You can also use Meshery to deploy your Meshery App to any of your connected kubernetes clusters. For more information, see [connections](/installation/kubernetes)