-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:offset fix w/signoff #11064
fix:offset fix w/signoff #11064
Conversation
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11064 +/- ##
==========================================
+ Coverage 9.00% 9.15% +0.14%
==========================================
Files 146 146
Lines 19274 19243 -31
==========================================
+ Hits 1736 1761 +25
+ Misses 17236 17180 -56
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
I don't know that I'm able to offer comment here... |
@MUzairS15 ready for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well change will be requires https://github.com/meshery/meshery/pull/11064/files#diff-8b6f6f0e21ae8f6da42e6d459095cb28d2ffc653770bbacf51288b3b46b927c9R545
and
meshery/ui/store/slices/events.js
Line 135 in b6031a7
if (page <= 1) { |
and
meshery/ui/store/slices/events.js
Line 6 in b6031a7
page: 1, |
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Notes for Reviewers
This PR fixes #
The PR fix for API is malfunctioning for pagination offset.
@MUzairS15 please look if it doesn't break other api haven't been able to try on all of them so please do verify once before merging .
Signed commits