Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:offset fix w/signoff #11064

Merged
merged 6 commits into from
Jun 4, 2024
Merged

fix:offset fix w/signoff #11064

merged 6 commits into from
Jun 4, 2024

Conversation

Jougan-0
Copy link
Contributor

@Jougan-0 Jougan-0 commented May 28, 2024

Notes for Reviewers

This PR fixes #

The PR fix for API is malfunctioning for pagination offset.

@MUzairS15 please look if it doesn't break other api haven't been able to try on all of them so please do verify once before merging .
Signed commits

  • Yes, I signed my commits.

Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Copy link

github-actions bot commented May 28, 2024

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 9.15%. Comparing base (17acf25) to head (89c312b).
Report is 122 commits behind head on master.

Current head 89c312b differs from pull request most recent head 069414f

Please upload reports for the commit 069414f to get more accurate results.

Files Patch % Lines
server/handlers/utils.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11064      +/-   ##
==========================================
+ Coverage    9.00%    9.15%   +0.14%     
==========================================
  Files         146      146              
  Lines       19274    19243      -31     
==========================================
+ Hits         1736     1761      +25     
+ Misses      17236    17180      -56     
  Partials      302      302              
Flag Coverage Δ
unittests 9.15% <0.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the component/ui User Interface label May 29, 2024
@leecalcote
Copy link
Member

I don't know that I'm able to offer comment here...

@leecalcote
Copy link
Member

@MUzairS15 ready for your review.

Copy link
Contributor

@MUzairS15 MUzairS15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
@Jougan-0 Jougan-0 mentioned this pull request Jun 3, 2024
10 tasks
@MUzairS15 MUzairS15 merged commit 6b91b45 into meshery:master Jun 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants