-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registry log dynamic #11065
Registry log dynamic #11065
Conversation
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11065 +/- ##
==========================================
- Coverage 9.19% 9.12% -0.08%
==========================================
Files 145 146 +1
Lines 19105 19297 +192
==========================================
+ Hits 1756 1760 +4
- Misses 17047 17235 +188
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shlok Mishra <99207534+Jougan-0@users.noreply.github.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
|
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
@Jougan-0 is there anything left here or are we merge-ready? |
For kubernetes if I remember correctly the event was not sent properly. Double checking and conforming. |
The meshkit needs to be merged first and then the go mod needs update. |
Got it. Ok, good to go - https://github.com/meshery/meshkit/releases/tag/v0.7.33 |
Signed-off-by: Shlok Mishra <99207534+Jougan-0@users.noreply.github.com>
|
Fixing Those it's the meshkit. |
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Fixed. |
@leecalcote This one good to go as well, if we update the meshkit release this needs to merge or release will break. |
Signed-off-by: Shlok Mishra <99207534+Jougan-0@users.noreply.github.com>
Notes for Reviewers
This PR fixes #10567
Handles all the registration using my local repo meshkit needs to merge it first .
Event offset issue fix Pr needs to be merged to for this pr to work perfectly.
Signed commits