Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry log dynamic #11065

Merged
merged 9 commits into from
Jun 17, 2024
Merged

Registry log dynamic #11065

merged 9 commits into from
Jun 17, 2024

Conversation

Jougan-0
Copy link
Contributor

@Jougan-0 Jougan-0 commented May 29, 2024

Notes for Reviewers

This PR fixes #10567

Handles all the registration using my local repo meshkit needs to merge it first .
Event offset issue fix Pr needs to be merged to for this pr to work perfectly.

  • - Replaced instance of owner Id with the system ID that is instance Id .
  • - Logs are written every time the RegistryEntity function is called.
  • - For different registration if you want just need to call the HandlerError function with that host will work with all the registrants .
  • - Use A file under ./meshery/logs that is created at the start when server runs and then it is written by the variable whenever the RegistryAttempts is updated.
  • - Changed the Name of function and endpoint to be more generic and that makes better sense.
  • Kubernetes Event Updated.
  • Handles Multiple Registrants.
  • Logs format update.
  • Docs dry run built done .
    image
    image

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
@github-actions github-actions bot added component/ui User Interface component/server area/models Models, Components, Relationships related changes labels May 29, 2024
@Jougan-0 Jougan-0 added the pr/do-not-merge PRs not ready to be merged label May 29, 2024
Copy link

github-actions bot commented May 29, 2024

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 1.97044% with 199 lines in your changes missing coverage. Please review.

Project coverage is 9.12%. Comparing base (c90e488) to head (ab335a1).
Report is 27 commits behind head on master.

Current head ab335a1 differs from pull request most recent head 0bbdd7f

Please upload reports for the commit 0bbdd7f to get more accurate results.

Files Patch % Lines
server/helpers/common_registry_logs.go 2.96% 131 Missing ⚠️
server/handlers/common_handlers.go 0.00% 32 Missing ⚠️
server/cmd/main.go 0.00% 10 Missing ⚠️
server/handlers/component_generation.go 0.00% 8 Missing ⚠️
server/handlers/component_handler.go 0.00% 7 Missing ⚠️
server/handlers/relationship_handlers.go 0.00% 7 Missing ⚠️
server/handlers/events_streamer.go 0.00% 2 Missing ⚠️
server/router/server.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11065      +/-   ##
==========================================
- Coverage    9.19%    9.12%   -0.08%     
==========================================
  Files         145      146       +1     
  Lines       19105    19297     +192     
==========================================
+ Hits         1756     1760       +4     
- Misses      17047    17235     +188     
  Partials      302      302              
Flag Coverage Δ
unittests 9.12% <1.97%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Jougan-0 and others added 2 commits June 4, 2024 01:01
Signed-off-by: Shlok Mishra <99207534+Jougan-0@users.noreply.github.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
@Jougan-0
Copy link
Contributor Author

Jougan-0 commented Jun 3, 2024

  • Kubernetes Event Updated.
  • Handles Multiple Registrants.
  • Logs format update.
  • Docs dry run built done .

@Jougan-0 Jougan-0 requested a review from MUzairS15 June 3, 2024 19:53
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
@leecalcote
Copy link
Member

leecalcote commented Jun 17, 2024

@Jougan-0 is there anything left here or are we merge-ready?

@Jougan-0
Copy link
Contributor Author

@Jougan-0 is there anything left here or are we merge-ready?

For kubernetes if I remember correctly the event was not sent properly. Double checking and conforming.

@Jougan-0
Copy link
Contributor Author

The meshkit needs to be merged first and then the go mod needs update.

@leecalcote
Copy link
Member

The meshkit needs to be merged first and then the go mod needs update.

Got it. Ok, good to go - https://github.com/meshery/meshkit/releases/tag/v0.7.33

Signed-off-by: Shlok Mishra <99207534+Jougan-0@users.noreply.github.com>
@leecalcote
Copy link
Member

Error: server/helpers/common_registry_logs.go:68:20: undefined: meshmodel.ErrEmptySchema

@leecalcote leecalcote added language/go Issues or pull requests that use Golang and removed pr/do-not-merge PRs not ready to be merged labels Jun 17, 2024
@Jougan-0
Copy link
Contributor Author

Error: server/helpers/common_registry_logs.go:68:20: undefined: meshmodel.ErrEmptySchema

Fixing Those it's the meshkit.

Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
@Jougan-0
Copy link
Contributor Author

Error: server/helpers/common_registry_logs.go:68:20: undefined: meshmodel.ErrEmptySchema

Fixed.

@Jougan-0
Copy link
Contributor Author

@leecalcote This one good to go as well, if we update the meshkit release this needs to merge or release will break.

Signed-off-by: Shlok Mishra <99207534+Jougan-0@users.noreply.github.com>
@leecalcote leecalcote merged commit 2a69427 into meshery:master Jun 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/models Models, Components, Relationships related changes component/server component/ui User Interface language/go Issues or pull requests that use Golang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants