Update contributing-model-relationships.md #11377
Conversation
Signed-off-by: Nithish Karthik <75248557+humblenginr@users.noreply.github.com>
|
🚀 Preview for commit 5ebf37e at: https://6690136ce471f914b33fb6c4--meshery-docs-preview.netlify.app |
| @@ -330,6 +329,8 @@ Each policy has a set of evaluation rules defined and the `evaluationQuery` attr | |||
| 1. To configure a relationship to be applied across all versions of a particular model, ensure the `version` property for those relationships is set to `*`, to limit the relationships to a specific version of a model, specify the correct model version. | |||
| 1. Specify `version` property as a regex to ensure relationships are applied to a subset of versions of a model. | |||
|
|
|||
| {% include alert.html title="Caution While Defining Relationships" type="warning" content="Relationships are not imported directly and they have to be packaged inside a model. Use caution when defining relationships that span models." %} | |||
There was a problem hiding this comment.
| {% include alert.html title="Caution While Defining Relationships" type="warning" content="Relationships are not imported directly and they have to be packaged inside a model. Use caution when defining relationships that span models." %} | |
| {% include alert.html title="Gratuitous Scoping of Relationships" type="warning" content="Relationships are not imported directly and they have to be packaged inside a model. Use caution when defining relationships that span models." %} |
There was a problem hiding this comment.
"Relationships are not imported directly and they have to be packaged inside a model." There is some relevance of this information to the warning, but it's not clear what that is given this phrasing and lack of explanation. Please revisit.
There was a problem hiding this comment.
"Use caution when defining relationships that span models." Great. Why? Where's the explanation here?
There was a problem hiding this comment.
Reviewing again...
This feedback will need to be incorporated prior to merge.
There was a problem hiding this comment.
This feedback has not been addressed.
| @@ -330,6 +329,8 @@ Each policy has a set of evaluation rules defined and the `evaluationQuery` attr | |||
| 1. To configure a relationship to be applied across all versions of a particular model, ensure the `version` property for those relationships is set to `*`, to limit the relationships to a specific version of a model, specify the correct model version. | |||
| 1. Specify `version` property as a regex to ensure relationships are applied to a subset of versions of a model. | |||
|
|
|||
| {% include alert.html title="Caution While Defining Relationships" type="warning" content="Relationships are not imported directly and they have to be packaged inside a model. Use caution when defining relationships that span models." %} | |||
There was a problem hiding this comment.
"Relationships are not imported directly and they have to be packaged inside a model." There is some relevance of this information to the warning, but it's not clear what that is given this phrasing and lack of explanation. Please revisit.
| @@ -330,6 +329,8 @@ Each policy has a set of evaluation rules defined and the `evaluationQuery` attr | |||
| 1. To configure a relationship to be applied across all versions of a particular model, ensure the `version` property for those relationships is set to `*`, to limit the relationships to a specific version of a model, specify the correct model version. | |||
| 1. Specify `version` property as a regex to ensure relationships are applied to a subset of versions of a model. | |||
|
|
|||
| {% include alert.html title="Caution While Defining Relationships" type="warning" content="Relationships are not imported directly and they have to be packaged inside a model. Use caution when defining relationships that span models." %} | |||
There was a problem hiding this comment.
"Use caution when defining relationships that span models." Great. Why? Where's the explanation here?
leecalcote
added
the
area/models
|
@humblenginr Could we discuss this issue during the Meshery dev meeting call? Please add it as an agenda item to the meeting minutes. |
|
@humblenginr, thoughts on the feedback offered? Please accept or reject each point of feedback. |
Co-authored-by: Lee Calcote <leecalcote@gmail.com> Signed-off-by: Nithish Karthik <75248557+humblenginr@users.noreply.github.com>
|
🚀 Preview for commit ba04c00 at: https://669a5eabb2a59436b89e90e3--meshery-docs-preview.netlify.app |
Signed-off-by: Nithish Karthik <nithishkarthik01@gmail.com>
|
Updated the warning |
|
🚀 Preview for commit 0ad4ecc at: https://669b21d028818da1854f9ebe--meshery-docs-preview.netlify.app |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
stale
bot
removed
the
issue/stale
Notes for Reviewers
This PR fixes #
Signed commits