Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug golangci-lint #5988

Closed
wants to merge 11 commits into from
Closed

Debug golangci-lint #5988

wants to merge 11 commits into from

Conversation

nishantwrp
Copy link
Member

Description
Debug the failures of golangci-lint. This pr is for debug purpose only as i am not able to reproduce the failure locally.

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@nishantwrp nishantwrp added the pr/do-not-merge PRs not ready to be merged label Aug 6, 2022
@github-actions github-actions bot added the component/mesheryctl CLI for Meshery label Aug 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2022

Codecov Report

Merging #5988 (6552f6b) into master (2386f1d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5988   +/-   ##
=======================================
  Coverage   17.92%   17.92%           
=======================================
  Files         110      110           
  Lines       10421    10421           
=======================================
  Hits         1868     1868           
  Misses       8096     8096           
  Partials      457      457           
Flag Coverage Δ
e2etests ∅ <ø> (?)
gointegrationtests 6.38% <ø> (ø)
integrationtests ∅ <ø> (?)
unittests 13.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
helpers/helpers.go 0.00% <ø> (ø)
mesheryctl/pkg/utils/auth.go 10.62% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@github-actions github-actions bot added the area/ci Continuous Integration label Aug 6, 2022
@leecalcote
Copy link
Member

I went ahead and bumped the version of golangci-lint up by one minor version.

This reverts commit cbd2088.
This reverts commit 4390d8e.
@github-actions github-actions bot removed the area/ci Continuous Integration label Aug 7, 2022
@github-actions github-actions bot added the area/ci Continuous Integration label Aug 7, 2022
@nishantwrp nishantwrp closed this Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous Integration component/mesheryctl CLI for Meshery pr/do-not-merge PRs not ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants