Debug golangci-lint

.github/workflows/build-ui-and-server.yml

@@ -36,7 +36,7 @@ jobs:
         uses: golangci/golangci-lint-action@v3.2.0
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
-          version: latest
+          version: v1.47.3
 
           # Optional: working directory, useful for monorepos
           # working-directory: somedir
@@ -337,4 +337,3 @@ jobs:
           cd docs
           bundle install
           bundle exec rake graphql:compile_docs
-

.github/workflows/mesheryctl-ci.yml

@@ -32,7 +32,7 @@ jobs:
         uses: golangci/golangci-lint-action@v3.2.0
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
-          version: latest
+          version: v1.47.3
           # Optional: working directory, useful for monorepos
           working-directory: mesheryctl
 
@@ -94,7 +94,7 @@ jobs:
           check-latest: "true"
       - name: Run script 📜
         run: |
-          cd mesheryctl/doc 
+          cd mesheryctl/doc
           go run doc.go
       - name: Commit ✅
         uses: stefanzweifel/git-auto-commit-action@v4
@@ -105,4 +105,3 @@ jobs:
           commit_author: ${{ github.actor }} <${{ github.actor }}@users.noreply.github.com>
           commit_options: "--signoff"
           commit_message: "[Docs] Update mesheryctl docs"
-

.golangci.yml

@@ -42,7 +42,7 @@ linters-settings:
     settings:
       mnd:
         # don't include the "operation" and "assign"
-        checks: 
+        checks:
           - argument
           - case
           - condition
@@ -150,10 +150,4 @@ run:
     - internal/renameio
     - internal/robustio
   timeout: 5m
-
-# golangci.com configuration
-# https://github.com/golangci/golangci/wiki/Configuration
-service:
-  golangci-lint-version: 1.45.2 # use the fixed version to not introduce new linters unexpectedly
-  prepare:
-    - echo "here I can run custom commands, but no preparation needed for this repo"
+  go: '1.17'

helpers/helpers.go

@@ -24,6 +24,7 @@ func MergeStringMaps(maps ...map[string]string) map[string]string {
 }
 
 func ResolveFSRef(path string) (string, error) {
+	// other useless comment
 	return utils.ReadFileSource(fmt.Sprintf("file://%s", path))
 }
 

mesheryctl/Makefile

@@ -5,7 +5,6 @@ RELEASE_CHANNEL="edge"
 LDFLAGS="-w -s -X github.com/layer5io/meshery/mesheryctl/internal/cli/root/constants.version=${GIT_VERSION} -X github.com/layer5io/meshery/mesheryctl/internal/cli/root/constants.commitsha=${GIT_COMMITSHA} -X github.com/layer5io/meshery/mesheryctl/internal/cli/root/constants.releasechannel=${RELEASE_CHANNEL}"
 
 make:
-	gofmt -l -s -w .
 	go build -ldflags=${LDFLAGS} -o mesheryctl cmd/mesheryctl/main.go
 forwin:
 	go build -ldflags=${LDFLAGS} -o mesheryctl.exe cmd/mesheryctl/main.go

mesheryctl/pkg/utils/auth.go

@@ -29,6 +29,7 @@ type Provider struct {
 // NewRequest creates *http.Request and handles adding authentication for Meshery itself
 // Function returns a http response generated by the new request
 func NewRequest(method string, url string, body io.Reader) (*http.Request, error) {
+	// useless comment
 	// create new request
 	req, err := http.NewRequest(method, url, body)
 	if err != nil {