Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Workflow update meshery.io docs with meshmodel components #6838

Merged

Conversation

gr455
Copy link
Member

@gr455 gr455 commented Jan 4, 2023

Existing script to update meshmodel components now also updates the components docs for meshery.io repository. Before this commit, the script only updated docs for the Layer5.io repository

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Existing script to update meshmodel components now also updates the
components docs for meshery.io repository. Before this commit, the
script only updated docs for the Layer5.io repository

Signed-off-by: Ruturaj Mohite <mohite.ruturaj15@gmail.com>
@github-actions github-actions bot added the area/ci Continuous Integration label Jan 4, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 16.63% // Head: 16.61% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (8ccbdc9) compared to base (b64d6b8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6838      +/-   ##
==========================================
- Coverage   16.63%   16.61%   -0.02%     
==========================================
  Files         116      116              
  Lines       11319    11319              
==========================================
- Hits         1883     1881       -2     
- Misses       8961     8963       +2     
  Partials      475      475              
Flag Coverage Δ
gointegrationtests 5.66% <ø> (-0.02%) ⬇️
integrationtests ∅ <ø> (?)
unittests 12.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mesheryctl/internal/cli/root/system/start.go 57.87% <0.00%> (-0.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leecalcote
Copy link
Member

@gr455 the GitHub workflow changes are on the money. Have you been able to successfully build meshery.io with the output from the revised .json data file?

@leecalcote leecalcote merged commit bbe49b5 into meshery:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants