-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try pinning Node v18.12.1 and use openssl legacy flags to fix open-ssl webpack nodejs error cy integration tests run thrown after Meshery UI is started in dev mode #6865
Conversation
Please note that I have already done some of the leg work on this PR, which will explain some of the packages that broke in the CI build and local development. I added Please note that in the midst of migrating to MUI v5, see here on MUI installation page where they are relying on React 17. https://mui.com/system/styles/basics/ So in my PR, I suggested to upgrade to minimum Next 12. Because when it comes to migrating MUI from v4 to v5, I also suggest using
https://mui.com/system/styles/basics/ So it is either go all in, and skip To finalize this, we can use
|
504caf4
to
8389c37
Compare
64809b3
to
7f46c27
Compare
While making changes to this PR, I ran into this issue. INFO[2023-01-10T21:35:39-06:00] Updated object: cluster-dns/kube-system of kind: ConfigMap in the database app=meshery
DEBU[0181] No valid mesh adapter(s) found. file=events_streamer
DEBU[0186] No valid mesh adapter(s) found. file=events_streamer
DEBU[0191] No valid mesh adapter(s) found. file=events_streamer
DEBU[0196] No valid mesh adapter(s) found. file=events_streamer
DEBU[0201] No valid mesh adapter(s) found. file=events_streamer
DEBU[0206] No valid mesh adapter(s) found. file=events_streamer
DEBU[0211] No valid mesh adapter(s) found. file=events_streamer
DEBU[0216] No valid mesh adapter(s) found. file=events_streamer
DEBU[0221] No valid mesh adapter(s) found. file=events_streamer
INFO[2023-01-10T21:36:19-06:00] k3d-k3s-default components for contextID:14b3dd7438b74b84525dd6ff0091ab59 registered app=meshery
panic: definitions: field not found: a
goroutine 16664 [running]:
github.com/layer5io/meshery/server/models/meshmodel/core.getResolvedManifest({0xc007646000, 0x3f8014})
/home/phxvlabs-io/go/src/github.com/workspace/meshery/server/models/meshmodel/core/register.go:158 +0x31e
github.com/layer5io/meshery/server/models/meshmodel/core.getCRDsFromManifest({0xc007646000?, 0xc005886000?}, {0xc0005a6000, 0x4f, 0x0?})
/home/phxvlabs-io/go/src/github.com/workspace/meshery/server/models/meshmodel/core/register.go:165 +0x46
github.com/layer5io/meshery/server/models/meshmodel/core.GetK8sMeshModelComponents({0x40ad560?, 0xc006a88480?}, {0xc000cf5000?, 0x192?, 0x5d?})
/home/phxvlabs-io/go/src/github.com/workspace/meshery/server/models/meshmodel/core/register.go:119 +0x5eb
github.com/layer5io/meshery/server/handlers.RegisterK8sMeshModelComponents({0x463d4f8?, 0xc000122000?}, {0xc000cf5000?, 0xf?, 0xc0011c2ae0?}, {0xc001d431a0, 0x20}, 0x15?)
/home/phxvlabs-io/go/src/github.com/workspace/meshery/server/handlers/k8sconfig_handler.go:349 +0x5e
github.com/layer5io/meshery/server/models.(*ComponentsRegistrationHelper).RegisterComponents.func1(0xc001123440?)
/home/phxvlabs-io/go/src/github.com/workspace/meshery/server/models/k8s_components_registration.go:94 +0x25e
created by github.com/layer5io/meshery/server/models.(*ComponentsRegistrationHelper).RegisterComponents
/home/phxvlabs-io/go/src/github.com/workspace/meshery/server/models/k8s_components_registration.go:71 +0x58a
exit status 2
make: *** [Makefile:103: server] Error 1 Will need this fixed before I can move forward. |
7f46c27
to
71efb12
Compare
@acald-creator here's some warnings, not sure if we can ignore them for now:
But now it seems that running the Meshery UI dev server doesn't fail although cypress fails because of some uncaught exception in the frontend (which I've seen before), I'll see if I can fix it by following "cypress handling errors" recipe we've used in the past:
|
The first part can be ignored for now. This is something that will needs to be configured in The second part refers to when redux and websocket is being called for, and in the process, I believe there is not a timer to check for redux and also websocket until it is actually up. Last I check in the processing of building UI and the server, there is a delay before the server is officially up, where the ui is already looking for the server to be running. Therefore, the error comes up. |
Signed-off-by: Mario Arriaga <ing.mario.arriaga@gmail.com>
c51dbc2
to
1bbced8
Compare
Signed-off-by: Mario Arriaga <ing.mario.arriaga@gmail.com>
Good to close this out? |
We can close this out for now, as we're using Node 18 in GitHub Actions, and I will need to do some research on how to use Cypress to test for changes from Redux/React-Redux. We are also we |
Notes for Reviewers
This PR fixes #6864.
Trying this out don't merge yet please.
Signed commits