Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes on NPM packages #6888

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Minor changes on NPM packages #6888

merged 4 commits into from
Jan 27, 2023

Conversation

acald-creator
Copy link
Contributor

Upgraded

  • react-select
  • react-countdown-clock
  • isomorphic-unfetch

Installed MUI v5 and graphql-ws as placeholder.

  • Material V4 has stopped received updates as of September 2021
  • subscription-transport-ws has deprecated and moved to graphql-ws
  • Installed these as a placeholder
  • GraphQL may require a design review on the setup. There are some websocket dependencies issues.

Signed-off-by: Antonette Caldwell pullmana8@gmail.com

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

@acald-creator
Minor change: Upgraded react-select, react-countdown-clock and isomor…
424d36d 
…phic-unfetch, installed MUI and graphql-ws as placeholder

Signed-off-by: Antonette Caldwell <pullmana8@gmail.com>
@github-actions github-actions bot added the component/ui User Interface label Jan 14, 2023
@leecalcote
Copy link
Member

@Harshit-Dandriyal will you test and confirm functionality given the description that @acald-creator has included?

@leecalcote
Copy link
Member

Using the Local Provider and visiting /user/preferences, an overly large performance icon is displayed.

Screenshot 2023-01-15 at 5 37 05 PM

@Abhishek-kumar09
Copy link
Member

Using the Local Provider and visiting /user/preferences, an overly large performance icon is displayed.

Screenshot 2023-01-15 at 5 37 05 PM

#6690 solves this

@acald-creator acald-creator mentioned this pull request Jan 16, 2023
Closed
Abhishek-kumar09
Abhishek-kumar09 approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@Abhishek-kumar09 Abhishek-kumar09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is "Minor" change and complete migration is to be carried out afterwards, I approve this PR.

@Abhishek-kumar09 Abhishek-kumar09 mentioned this pull request Jan 16, 2023
Closed
3 tasks
theBeginner86
theBeginner86 approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@theBeginner86 theBeginner86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@leecalcote leecalcote merged commit 886473f into meshery:master Jan 27, 2023
@acald-creator acald-creator deleted the minor-upgrade-nextjs branch January 30, 2023 16:36
@senali-d senali-d mentioned this pull request Sep 27, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhishek-kumar09 Abhishek-kumar09 Abhishek-kumar09 approved these changes

@theBeginner86 theBeginner86 theBeginner86 approved these changes

@leecalcote leecalcote Awaiting requested review from leecalcote

@Harshit-Dandriyal Harshit-Dandriyal Awaiting requested review from Harshit-Dandriyal

@MUzairS15 MUzairS15 Awaiting requested review from MUzairS15

Assignees
No one assigned
Labels
component/ui User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acald-creator @leecalcote @Abhishek-kumar09 @theBeginner86