New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Roboto Font with Qanelas Soft Font #8901
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Senali <senalidilumika@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@senali-d I think you missed pushing the font changes...
@Chadha93 Reason: |
Right, I meant, will this change the font to all the components in Meshery UI? Yes, we've defined it in the theme. ✔️ |
Ok I'll check other components as well. |
Signed-off-by: Senali <senalidilumika@gmail.com>
Aligning the project on the typography used in the design system will certainly give Meshery more polish. |
Let's discuss this on the Meshery dev call tomorrow, |
merge conflicts |
…s/font-8863 Signed-off-by: Senali <senalidilumika@gmail.com>
@@ -15,7 +15,7 @@ import AppBarComponent from './styledComponents/AppBar'; | |||
|
|||
import DeleteIcon from '@material-ui/icons/Delete'; | |||
import SaveIcon from '@material-ui/icons/Save'; | |||
import { AvatarGroup } from '@mui/material'; | |||
import { AvatarGroup } from '@material-ui/core'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ideal to use core elements from mui. Since we need to move to mui V5 then again we have to revert these changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this changes fixed theme defined fonts was not in using MUI components when we import it from MUI v5.
Accidentally import MUI v5 components was fixed when we remove Ref: #6888 |
Thanks @senali-d |
After we remove all references to mui5 let's remove it from package.json |
…s/font-8863 Signed-off-by: Senali <senalidilumika@gmail.com>
@aabidsofi19 Meshery ui already use Note: Some of the icons are newly introduced in |
Merge conflict, @senali-d |
…s/font-8863 Signed-off-by: Senali <senalidilumika@gmail.com>
@leecalcote Fixed conflicts |
@senali-d it could have been something else, but I seem to get this crash when running this branch (on the dashboard): |
@senali-d this item is in your court, I believe. |
Yup, I think build issue is not relate to changes in this pr. I'll open a new pr for this. |
Recently Meshery UI is Migrate from MUI V4 to MUI V5. Ref: #9319 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@senali-d please push this over the line. |
Notes for Reviewers
This PR fixes #8863
Signed commits