Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Roboto Font with Qanelas Soft Font #8901

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

senali-d
Copy link
Member

Notes for Reviewers

This PR fixes #8863

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Senali <senalidilumika@gmail.com>
Copy link
Member

@Chadha93 Chadha93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@senali-d I think you missed pushing the font changes...

@senali-d
Copy link
Member Author

@senali-d I think you missed pushing the font changes...

@Chadha93
What I have done here is instead of "@mui/material" Chip component import the @material-ui/core Chip.

Reason:
We have already define font-family in custom theme file. So it is override @material-ui/core component fronts but not the "@mui/material".
So when use @material-ui/core component no need to override the component level styles. Theme file apply here and override the MUI styles.

@Chadha93
Copy link
Member

@senali-d I think you missed pushing the font changes...

@Chadha93 What I have done here is instead of "@mui/material" Chip component import the @material-ui/core Chip.

Reason: We have already define font-family in custom theme file. So it is override @material-ui/core component fronts but not the "@mui/material". So when use @material-ui/core component no need to override the component level styles. Theme file apply here and override the MUI styles.

Right, I meant, will this change the font to all the components in Meshery UI? Yes, we've defined it in the theme. ✔️

@senali-d
Copy link
Member Author

Right, I meant, will this change the font to all the components in Meshery UI? Yes, we've defined it in the theme. ✔️

Ok I'll check other components as well.

Signed-off-by: Senali <senalidilumika@gmail.com>
@hamza-mohd
Copy link
Contributor

Aligning the project on the typography used in the design system will certainly give Meshery more polish.

@saurabh100ni
Copy link
Contributor

Let's discuss this on the Meshery dev call tomorrow,
Please add this as your agenda item in Docs: https://docs.google.com/document/d/1Dg4Uz9rGTuGHmYZwIt47z1j5x3LmnpxD1M1SgypAkQ0/edit

@leecalcote
Copy link
Member

merge conflicts

…s/font-8863

Signed-off-by: Senali <senalidilumika@gmail.com>
@@ -15,7 +15,7 @@ import AppBarComponent from './styledComponents/AppBar';

import DeleteIcon from '@material-ui/icons/Delete';
import SaveIcon from '@material-ui/icons/Save';
import { AvatarGroup } from '@mui/material';
import { AvatarGroup } from '@material-ui/core';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ideal to use core elements from mui. Since we need to move to mui V5 then again we have to revert these changes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this changes fixed theme defined fonts was not in using MUI components when we import it from MUI v5.

@senali-d
Copy link
Member Author

Accidentally import MUI v5 components was fixed when we remove MUI v5 package. Is it possible?? // @aabidsofi19 @nebula-aac

Ref: #6888

@aabidsofi19
Copy link
Contributor

Thanks @senali-d

@aabidsofi19
Copy link
Contributor

After we remove all references to mui5 let's remove it from package.json

…s/font-8863

Signed-off-by: Senali <senalidilumika@gmail.com>
@senali-d
Copy link
Member Author

After we remove all references to mui5 let's remove it from package.json

@aabidsofi19 Meshery ui already use MUI v5 icons. From the package @mui/icons-material so it depend on @mui/material. So we can't remove MUI v5 from package.json.

Note: Some of the icons are newly introduced in v5

@leecalcote
Copy link
Member

Merge conflict, @senali-d

…s/font-8863

Signed-off-by: Senali <senalidilumika@gmail.com>
@senali-d
Copy link
Member Author

senali-d commented Oct 3, 2023

@leecalcote Fixed conflicts

@leecalcote
Copy link
Member

leecalcote commented Oct 3, 2023

@senali-d it could have been something else, but I seem to get this crash when running this branch (on the dashboard):
Screenshot 2023-10-03 at 4 57 34 PM

@leecalcote
Copy link
Member

@senali-d this item is in your court, I believe.

@senali-d
Copy link
Member Author

senali-d commented Nov 1, 2023

@senali-d this item is in your court, I believe.

Yup, I think build issue is not relate to changes in this pr. I'll open a new pr for this.

@senali-d
Copy link
Member Author

senali-d commented Nov 8, 2023

Recently Meshery UI is Migrate from MUI V4 to MUI V5. Ref: #9319
So once done it no need these changes. Use of the new theme of MUI v5 fill fix this issue.

Copy link

stale bot commented Dec 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Dec 19, 2023
@leecalcote leecalcote added the issue/willfix This issue will be worked on label Dec 19, 2023
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Dec 19, 2023
@leecalcote
Copy link
Member

@senali-d please push this over the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface issue/willfix This issue will be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Roboto Font with Qanelas Soft Font
8 participants