Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all dryRun errors and change response format #7149

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Feb 22, 2023

Notes for Reviewers

This PR fixes all dryRunError issues and improves on responses.
Examples are attached below: (success field must be used by clients to see if they need to check error or component)

  1. On failure of dry run:

Screenshot 2023-02-22 at 5 30 54 PM

  1. On success of dry run returning a service/component that would be deployed:

Screenshot 2023-02-22 at 5 32 28 PM

The response encapsulates:
{
"component-name":{
"contextID":{
RESPONSE
}
}

}
Signed commits

  • Yes, I signed my commits.

Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Base: 16.48% // Head: 16.44% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (007214f) compared to base (2acaeed).
Patch coverage: 0.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7149      +/-   ##
==========================================
- Coverage   16.48%   16.44%   -0.05%     
==========================================
  Files         118      118              
  Lines       16241    16281      +40     
==========================================
  Hits         2677     2677              
- Misses      13080    13120      +40     
  Partials      484      484              
Flag Coverage Δ
e2etests ∅ <ø> (?)
gointegrationtests 5.68% <0.00%> (-0.02%) ⬇️
unittests 12.24% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/handlers/component_handler.go 0.00% <0.00%> (ø)
server/handlers/oam_handler.go 0.00% <0.00%> (ø)
server/models/pattern/stages/dry_run.go 0.00% <ø> (ø)
server/models/pattern/stages/validate.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contributor docs? or API docs?

leecalcote
leecalcote previously approved these changes Feb 22, 2023
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a diagram in the Meshery Architecture deck.

Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants