Fix Hover #8989
Merged
Fix Hover #8989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+613
to
+626
| <img | ||
| src={icon} | ||
| className={classes.icon} | ||
| onMouseOver={(e) => { | ||
| e.target.style.transform = 'translate(-20%, -25%)'; | ||
| e.target.style.top = '0'; | ||
| e.target.style.right = '0'; | ||
| }} | ||
| onMouseOut={(e) => { | ||
| e.target.style.transform = 'translate(0, 0)'; | ||
| e.target.style.top = 'auto'; | ||
| e.target.style.right = 'auto'; | ||
| }} | ||
| /> |
There was a problem hiding this comment.
This is good, but can we use standardizing through the use of our themes? // @Modern-artist @ritiksaxena124
There was a problem hiding this comment.
I was trying to do that. But I don't know why it doesn't work. One potential reason can be -
- The other icons of the navigator were coming natively but the meshmap icon was coming from the web. The other icons are JS versions of SVG but meshmap icon is pure SVG so the CSS wasn't working.
|
The resultant effect looks good. Please do consider incorporating, @theBeginner86's feedback |
|
Let's discuss this on the Meshery dev call tomorrow, |
|
LGTM 👍now |
leecalcote
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #8717
Screencast.from.02-10-23.01.34.02.AM.IST.webm
Signed commits