Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hover #8989

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Fix Hover #8989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 14 additions & 1 deletion ui/components/Navigator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,20 @@ class Navigator extends React.Component {
disableTouchListener={!drawerCollapsed}
>
<ListItemIcon className={classes.listIcon}>
<img src={icon} className={classes.icon} />
<img
src={icon}
className={classes.icon}
onMouseOver={(e) => {
e.target.style.transform = 'translate(-20%, -25%)';
e.target.style.top = '0';
e.target.style.right = '0';
}}
onMouseOut={(e) => {
e.target.style.transform = 'translate(0, 0)';
e.target.style.top = 'auto';
e.target.style.right = 'auto';
}}
/>
Comment on lines +613 to +626
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but can we use standardizing through the use of our themes? // @Modern-artist @ritiksaxena124

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to do that. But I don't know why it doesn't work. One potential reason can be -

  • The other icons of the navigator were coming natively but the meshmap icon was coming from the web. The other icons are JS versions of SVG but meshmap icon is pure SVG so the CSS wasn't working.

</ListItemIcon>
</Tooltip>
<ListItemText
Expand Down