Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] Form is not mobile responsive #28

Closed
Chadha93 opened this issue Nov 16, 2022 · 17 comments · Fixed by #34
Closed

[Site] Form is not mobile responsive #28

Chadha93 opened this issue Nov 16, 2022 · 17 comments · Fixed by #34
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working

Comments

@Chadha93
Copy link
Member

Current Behavior

image

Expected Behavior

Make the form responsive across every breakpoint.

Screenshots/Logs

Environment

  • Host OS: Mac Linux Windows
  • Platform: Docker or Kubernetes
  • Meshery Server Version: stable-v
  • Meshery Client Version: stable-v

Contributor Guides and Resources

@Chadha93 Chadha93 added good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working labels Nov 16, 2022
@akssshh
Copy link
Contributor

akssshh commented Nov 16, 2022

@Chadha93 Can you assign this to me?

@Chadha93
Copy link
Member Author

@Chadha93 Can you assign this to me?

Sure.

@akssshh
Copy link
Contributor

akssshh commented Nov 17, 2022

@Chadha93 Not able to run the site locally. Can you please guide me in setting up the project locally?

@Chadha93
Copy link
Member Author

@Chadha93 Not able to run the site locally. Can you please guide me in setting up the project locally?

@gogoiakash2311 You can use make setup-libs then make site. See the makefile. Yes we also need to add these instruction in contribution.md.

@AnnuCode
Copy link

Hi @gogoiakash2311, if it's okay with you, can I work on this issue?

@akssshh
Copy link
Contributor

akssshh commented Nov 18, 2022

Heyy @AnnuCode I'm already working on this issue.

@akssshh
Copy link
Contributor

akssshh commented Nov 18, 2022

@AnnuCode I have seen that you have already made a PR for this issue. Go for it. I'm unassigning myself from this issue.

@AnnuCode
Copy link

@gogoiakash2311 I mistakenly started working on this issue without noting that you have already been assigned this issue. So please go ahead and make the contribution :)

@akssshh
Copy link
Contributor

akssshh commented Nov 18, 2022

Okay!! then thanks

@akssshh
Copy link
Contributor

akssshh commented Nov 19, 2022

Preview for the issue #28 at: https://tangerine-raindrop-15674c.netlify.app/
@Chadha93 Let me know if any changes are required.
After that, I'll make a PR

@akssshh
Copy link
Contributor

akssshh commented Nov 19, 2022

Hey @Chadha93 I have made a PR #31 for this issue

@UtkarshMishra12
Copy link
Member

@gogoiakash2311 It's still not responsive below 300px 👀 Link

@akssshh
Copy link
Contributor

akssshh commented Nov 23, 2022

Thanks for informing me! I'll make another PR after I fix it.

@UtkarshMishra12
Copy link
Member

@gogoiakash2311 Let me know if you need any help. 😊

@akssshh
Copy link
Contributor

akssshh commented Nov 23, 2022

Sure

@Nikhil-Ladha
Copy link
Member

Nikhil-Ladha commented Nov 24, 2022

@gogoiakash2311 It's still not responsive below 300px eyes Link

TBH, we don't need to be responsive below 300px. I don't think any device has that low of a resolution; even if so, we can safely ignore it. Not a big deal.

However, in this case, it is not responsive up to 325px (the lowest presumed resolution), Please fix up to that at least in the current PR itself.

@akssshh
Copy link
Contributor

akssshh commented Nov 24, 2022

@Nikhil-Ladha I'll do that in the current PR itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working
Projects
None yet
5 participants