-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : Removing The Image from signup page section and making it responsive #43
fix : Removing The Image from signup page section and making it responsive #43
Conversation
Signed-off-by: Rahilsiddique <siddiquerahil19@gmail.com>
Signed-off-by: Rahilsiddique <siddiquerahil19@gmail.com>
✅ Deploy Preview for meshery-play ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the Discuss Callout
CSS to use margin
instead of padding
. Also, increase the top margin by 2rem for wider views.
And, the callout is getting hidden in smaller device width. That shouldn't be happening. Instead, it should come up after the form and above the community callout.
Also, please update the PR name to something more sensible. And, follow the same for future PRs. |
Signed-off-by: Rahilsiddique <siddiquerahil19@gmail.com>
…://github.com/Rahilsiddique/play into feature/rahil_siddique/signup-page-ui-changes
this is my current implimentation if you have any thing to add orr want anykind of change on this please let me know and thankyou for your time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can handle this configuration using CSS itself, no need to use hooks here.
Just make all 3 divs under 1 parent div, and add a flex-wrap: wrap
to the parent div, which would make the 3rd div (the Discuss Callout) come wrapped up and show at the bottom. Then, apply a position: relative
and top: -(some magic number)
and position it below the text up to 1024px or more. And, then after that update the CSS to top:0
for the Callout to make it move to the bottom.
Also, remove the console.log functions.
Signed-off-by: Rahilsiddique <siddiquerahil19@gmail.com>
Signed-off-by: Rahilsiddique <siddiquerahil19@gmail.com>
hey @Nikhil-Ladha, this is the final set of changes I have removed hooks and used position relative to adjust it in smaller devices and positioned it accordingly. |
Signed-off-by: Rahilsiddique <siddiquerahil19@gmail.com>
Signed-off-by: Rahilsiddique <siddiquerahil19@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Notes for Reviewers
This PR fixes #
#39
Signed commits