Moved try to catch all RemoteExceptions inside connection coroutine #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an uncaught RemoteException is thrown inside mainScope.handledLaunch, it is silently ignored, but leaves the mainScope in "cancelled" state and all subsequent coroutine calls using mainScope never actually execute the body of coroutine.
Proposed minimal fix is to enclose all remote invocations inside this particular coroutine with try/catch block. But perhaps we should think of a better way to handle exceptions, as handledLaunch is used in many other places.