Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display time ago and coords for users #259

Merged
merged 6 commits into from Mar 19, 2021
Merged

Conversation

Crotery
Copy link

@Crotery Crotery commented Mar 15, 2021

The lastSeen time is buggy, it shows only time without day. It would be more informative, if android app show real age of packet.
Also, there is no way to know, where the station is, using only android phone - let's show coordinates of station on Users List, because map cannot work offline and even there you cannot get the station coordinates :(
image

@randybb
Copy link

randybb commented Mar 15, 2021

Please add url for these coordinates in geo:latitude,longitude format - this will open these coordinates in mapping app (OruxMaps, Locus,...) + a calculated distance from your node would be helpful

@Crotery
Copy link
Author

Crotery commented Mar 16, 2021

Hi there,
distance is already shown near coords. The url is a good idea, agree!

@Crotery
Copy link
Author

Crotery commented Mar 16, 2021

dear devs,
Had to make changes to hwModelDeprecated due to compile problems. Seems like protobufs+master were broken.
Also, I could not setup testing data to show the coords, seems like protocol problem or so. Tested on real phone&1.2.10 firmware, works. There is a screenshot from emulator
image

@Crotery
Copy link
Author

Crotery commented Mar 16, 2021

here it is from phone
image

@randybb
Copy link

randybb commented Mar 16, 2021

I think distance and bearing between nodes is visible only on device itself, not in the app.

@Crotery
Copy link
Author

Crotery commented Mar 16, 2021

There is a code for distance and it's in the desingn...

But, seems it's broken in alpha, could not see it today while testing on latest master version. Hope it will be fixed, it is not about this PR
image

@geeksville
Copy link
Member

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/nodes-out-of-range-still-listed/2616/14

@geeksville
Copy link
Member

looks great! And a good discussion in this bug. Merging

@geeksville geeksville merged commit 8a18680 into meshtastic:master Mar 19, 2021
@geeksville
Copy link
Member

Had to make changes to hwModelDeprecated due to compile problems. Seems like protobufs+master were broken.

This I think is by intent, the submodule version in this project is locked to the version of the protobufs it was built with. Updating to master for protobufs may pull in not yet ready for android changes. I'll submit my devbranch with these changes.

Also, I could not setup testing data to show the coords, seems like protocol problem or so.

This isn't really documented but you can add this info to MockInterface as fake from device packets. Hopefully this app will be more testable in the future.

@Crotery
Copy link
Author

Crotery commented Mar 19, 2021

This isn't really documented but you can add this info to MockInterface as fake from device packets. Hopefully this app will be more testable in the future.

Yeah, there were some data (with position) and even I could change the name of node and it changed in emulator. But lat&long from the mockInterface somehow did not get to the UI, so I tested only on the phone.

Thanks for merging, waiting for the 1.2 release =)

@luxonn
Copy link

luxonn commented Mar 20, 2021

That's great. I have offline maps installed, it would be great to choose the application that you switch to after clicking coordinates or to be able to copy the coordinates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants