Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update permissions #323

Merged
merged 5 commits into from Dec 15, 2021
Merged

update permissions #323

merged 5 commits into from Dec 15, 2021

Conversation

andrekir
Copy link
Member

  • allow user to deny permissions (warn instead of error);
  • improve and better explain permission dialogs;
  • comply with Google's requirements for background location access.

references:
https://developer.android.com/training/location/permissions#request-background-location
https://support.google.com/googleplay/android-developer/answer/9799150

@andrekir andrekir linked an issue Dec 14, 2021 that may be closed by this pull request
@andrekir
Copy link
Member Author

  • added GPS sensor check;
  • added 'location only' logic to make sure we have it before asking for background location;
  • disabled WRITE_EXTERNAL_STORAGE (only used in debug).

@andrekir andrekir marked this pull request as ready for review December 15, 2021 15:13
@mc-hamster mc-hamster merged commit c0158b3 into master Dec 15, 2021
@geeksville
Copy link
Member

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/meshtastic-android-1-2-51-alpha/4503/1

@andrekir andrekir deleted the perms branch December 20, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New play store requirement: disclosure/warning page about positions
3 participants