Ext notify pin #975
Merged
Ext notify pin #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osmanovv
added a commit
to osmanovv/Meshtastic-device
that referenced
this pull request
Dec 17, 2021
In Meshtastic DIY `GPIO13` is used for `SX126X_TXEN`, so we choose `GPIO12` as default for Ext Notification Plugin.
|
This pull request has been mentioned on Meshtastic. There might be relevant details there: https://meshtastic.discourse.group/t/meshtastic-device-1-2-49-5354c49-alpha/4502/1 |
mc-hamster
added a commit
that referenced
this pull request
Dec 18, 2021
Overridden default pin to use for Ext Notify Plugin (#975)
|
This pull request has been mentioned on Meshtastic. There might be relevant details there: https://meshtastic.discourse.group/t/meshtastic-firmware-1-2-50-41dcfdd-alpha/4612/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates ExternalNotification Plugin and the board defines in configuration.h so that the default outbound gpio pin from the board configuration is defined as
EXT_NOTIFY_OUT. I've added in as many platforms that I could find that safely use the current default pin of 13. Other board maintainers please add a safe default as required.I've removed the function
BUTTON_PIN_ALTfrom tbeam 1.0, as this is an undocumented addition that only exists on this board. This should close issue #929.