Skip to content

Commit

Permalink
change name of old hw_model, to make sure any apps that use it are fo…
Browse files Browse the repository at this point in the history
…rced

to update their code. i.e. the android app at least.
  • Loading branch information
geeksville committed Mar 14, 2021
1 parent 943c3c2 commit e687637
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/docs.md
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ Sent to the phone in response to WantNodes.
| num_bands | [uint32](#uint32) | | # of frequencies that can be used (set at build time in the device flash image). Note: this is different from max_channels, this field is telling the # of frequency bands this node can use. (old name was num_channels) |
| max_channels | [uint32](#uint32) | | The maximum number of 'software' channels that can be set on this node. |
| region | [string](#string) | | **Deprecated.** Deprecated! ONLY USED IN DEVICE CODE (for upgrading old 1.0 firmwares) DO NOT READ ELSEWHERE. The region code for my radio (US, CN, etc...) Note: This string is deprecated. The 1.0 builds populate it based on the flashed firmware name. But for newer builds this string will be unpopulated (missing/null). For those builds you should instead look at the new read/write region enum in UserSettings The format of this string was 1.0-US or 1.0-CN etc.. Or empty string if unset. |
| hw_model | [string](#string) | | **Deprecated.** TBEAM, HELTEC, etc... Starting in 1.2.11 moved to hw_model enum in the NodeInfo object. Apps will still need the string here for older builds (so OTA update can find the right image), but if the enum is available it will be used instead. |
| hw_model_deprecated | [string](#string) | | **Deprecated.** TBEAM, HELTEC, etc... Starting in 1.2.11 moved to hw_model enum in the NodeInfo object. Apps will still need the string here for older builds (so OTA update can find the right image), but if the enum is available it will be used instead. |
| firmware_version | [string](#string) | | 0.0.5 etc... |
| error_code | [CriticalErrorCode](#CriticalErrorCode) | | An error message we'd like to report back to the mothership through analytics. It indicates a serious bug occurred on the device, the device coped with it, but we still want to tell the devs about the bug. This field will be cleared after the phone reads MyNodeInfo (i.e. it will only be reported once) a numeric error code to go with error message, zero means no error |
| error_address | [uint32](#uint32) | | A numeric error address (nonzero if available) |
Expand Down
2 changes: 1 addition & 1 deletion mesh.options
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
*Data.payload max_size:237

*MyNodeInfo.firmware_version max_size:12
*MyNodeInfo.hw_model max_size:16
*MyNodeInfo.hw_model_deprecated max_size:16
*MyNodeInfo.region max_size:12

# Note: the actual limit (because of header bytes) on the size of encrypted payloads is 251 bytes, but I use 256
Expand Down
2 changes: 1 addition & 1 deletion mesh.proto
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ message MyNodeInfo {
* Starting in 1.2.11 moved to hw_model enum in the NodeInfo object. Apps will still need the string here for older builds
* (so OTA update can find the right image), but if the enum is available it will be used instead.
*/
string hw_model = 5 [deprecated = true];
string hw_model_deprecated = 5 [deprecated = true];

/*
* 0.0.5 etc...
Expand Down

0 comments on commit e687637

Please sign in to comment.