Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: 0 Being used for Low Power and USB powered in Device Metrics #2332

Closed
garthvh opened this issue Mar 6, 2023 · 0 comments · Fixed by #2341
Closed

[Bug]: 0 Being used for Low Power and USB powered in Device Metrics #2332

garthvh opened this issue Mar 6, 2023 · 0 comments · Fixed by #2341
Assignees
@caveman99 @thebentern
Labels
bug Something isn't working

Comments

@garthvh
Copy link
Member

garthvh commented Mar 6, 2023

Category

Other

Hardware

Not Applicable

Firmware Version

2.0.0 +

Description

For device metrics we are using 0 to mean both low battery and connected by USB which I think is causing some of our battery confusion @caveman99 suggested we use a magic number under 127 to indicate powered going forwared

Relevant log output

No response
@garthvh garthvh added the bug Something isn't working label Mar 6, 2023
@garthvh garthvh changed the title [Bug]: [Bug]: 0 Being used for Low Power and USB powered in Device Metrics Mar 6, 2023
@thebentern thebentern self-assigned this Mar 9, 2023
@andrekir andrekir linked a pull request Mar 11, 2023 that will close this issue
Report special battery_level of > 100 instead of zero to indicate USB #2341
Merged
andrekir added a commit to meshtastic/Meshtastic-Android that referenced this issue Mar 12, 2023
@andrekir
refactor: update battery level convention
8bd955e 
reference meshtastic/firmware#2332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caveman99 caveman99

@thebentern thebentern

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Report special battery_level of > 100 instead of zero to indicate USB meshtastic/firmware
3 participants
@caveman99 @garthvh @thebentern