Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: HopStart not populated #4198

Closed
mrx23dot opened this issue Jun 28, 2024 · 6 comments
Closed

[Bug]: HopStart not populated #4198

mrx23dot opened this issue Jun 28, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@mrx23dot
Copy link

mrx23dot commented Jun 28, 2024

Category

Other

Hardware

Not Applicable

Firmware Version

?unknown sender version

Description

A HeltecV3 received
2024-06-28_231328_9y

then it relayed it as:
ff ff ff ff 7c 1e e5 e2 9c 20 3c 52 03 08 00 00 63 8c 48 c1 09 ad cc 0d d8 67 35 47 b6 1e 06 e1 01 5b ea 72 23

based on protocol
https://meshtastic.org/docs/overview/mesh-algo/#packet-header-flags
[12]=(0x03) is Packet Header
HopLimit = 3 // 4-1 ok
HopStart = 0 (original HopLimit) why isn't this populated via originator fw? should be 4..7

I assume other unknown node also uses meshtastic fw, but I don't know which version.

Relevant log output

No response

@mrx23dot mrx23dot added the bug Something isn't working label Jun 28, 2024
@mrx23dot
Copy link
Author

mrx23dot commented Jun 28, 2024

It's important to know intention, ie 7 means it is longrange msg

It would also help to see raw hex dump for received msgs in Debug window.

sure, not every msg is incorrect, not sure if it's correct on the head or not.

@GUVWAF
Copy link
Member

GUVWAF commented Jun 29, 2024

hopStart was added in 2.3. The transmitter and all nodes on the path towards you need at least this firmware version, otherwise it will get lost.

@GUVWAF GUVWAF closed this as completed Jun 29, 2024
@mrx23dot
Copy link
Author

What about first receiving node running new fw populating it with received hopcount?
It's still more meaningful than leaving it at 0.

@GUVWAF
Copy link
Member

GUVWAF commented Jun 29, 2024

Then it would be incorrect when there are multiple nodes with old firmware on the path.

@mrx23dot
Copy link
Author

But old nodes worst case override our implied hopStart back to zero,
it's a best effort estimation of what the original value was (can only get lower), it might/it might not propagate to the edge.

@GUVWAF
Copy link
Member

GUVWAF commented Jun 29, 2024

I'd prefer being sure it's either correct data or no available data above not knowing for sure whether it's incorrect or not.

That said, please encourage your mesh users to update their firmware instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants