Adjusted adc_multiplier for heltec2.1 and added adc_mulitplier_override #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty close in my local testing |
🤖 Pull request artifacts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE DO NOT MERGE YET.
Given that there seems to be no silver bullet to fix #769, this change should be considered a tool in the toolbox for dealing with the inconsistency of ADC measurements in the Heltec devices.
I'd like to get some sample data or feedback from other Heltec V2.1 users, because this gave a fairly accurate VBatt on my device, but I suspect there are some differences or quality control issues with the voltage divider circuit production that are causing different devices to be incompatible with the same ADC_MULTIPLIER value.
Here's how you can confirm that your device is indeed the Heltec v2.1
