Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SH1106 controller #180

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Conversation

mrvdb
Copy link
Contributor

@mrvdb mrvdb commented Jun 14, 2020

The SH1106 is almost indistinguisable from a SSD1306.

  • the nr of columns in the sh1106 is 132 vs 128
  • use the proper includes/library functions when in use

This needs meshtastic/esp8266-oled-ssd1306#1

Related to issue #178

The SH1106 is almost indistinguisable from a SSD1306.

- the nr of columns in the sh1106 is 132 vs 128
- use the proper includes/library functions when in use
@mrvdb
Copy link
Contributor Author

mrvdb commented Jun 14, 2020

  • I haven't seen a difference yet with the 132 vs 128 columns (largely I think because I haven't seen all the pages when actually using a channel)
  • it might be possible to use the display width to auto-detect the controller perhaps?

@geeksville
Copy link
Member

it might be possible to use the display width to auto-detect the controller perhaps?
Possibly. I really don't know because I haven't read the datasheets for either of these two chips. But I bet it would be possible to find some particular i2c register that is different between them and use that to "probe" to figure out which chip is stuffed. After doing that probe the correct class could be instantated.

I think that would be a great separate pull request if you wanted to add it. But your current approach looks fine to me.

@geeksville geeksville marked this pull request as ready for review June 15, 2020 19:29
@geeksville geeksville merged commit 075ff26 into meshtastic:master Jun 15, 2020
@mrvdb
Copy link
Contributor Author

mrvdb commented Jun 16, 2020

Thanks for merging this!. To make it complete, the lib PR needs to be merged as well, not sure if you missed that. (PR is here: meshtastic/esp8266-oled-ssd1306#1 )

@geeksville
Copy link
Member

@mrvdb ooh I did! thanks for reminding me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants