-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completely refrain from transmitting if duty cycle limit exceeded #1998
Conversation
🤖 Pull request artifacts
|
Duty cycle limitation will now automatically be overridden when user is set to is_licensed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - the generated files will be overwritten on proto regen... So we need to update that first.
There will likely need to be scope for being able to bypass the duty cycle restrictions and have encryption enabled at the same time. |
There is a separate LoRaConfig field 'override_duty_cycle'. It will be automatically set to true if you set the user to is_licensed, but it can also be manually set. |
With this, the device will completely refrain from transmitting if it is violating the hourly duty cycle. If it happens, it informs the client by generating a NAK with DUTY_CYCLE_LIMIT error (needs updated protobufs). Did some stress testing with the interactive simulator and then it works fine :)
Still have some doubts. I added a LoRaConfig bool to override it, but am not sure if we should always set this to true if you set the user to is_licensed (for HAMs). Furthermore, do we need to inform the client how many minutes we have to be silent before we can transmit again? Then we need an admin message for that I think.