Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a lot of thread housekeeping #2074

Merged
merged 13 commits into from
Dec 30, 2022
Merged

a lot of thread housekeeping #2074

merged 13 commits into from
Dec 30, 2022

Conversation

caveman99
Copy link
Sponsor Member

Switch them off when not needed / disabled.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2022

🤖 Pull request artifacts

file commit
pr2074-firmware-2.0.11.092a753.zip 092a753

thebentern added a commit to meshtastic/artifacts that referenced this pull request Dec 29, 2022
thebentern added a commit to meshtastic/artifacts that referenced this pull request Dec 29, 2022
thebentern added a commit to meshtastic/artifacts that referenced this pull request Dec 29, 2022
@thebentern
Copy link
Contributor

@caveman99 I replaced those instances with disable and I also made it return an int32_t so that we could return it in a runOnce

thebentern added a commit to meshtastic/artifacts that referenced this pull request Dec 29, 2022
thebentern added a commit to meshtastic/artifacts that referenced this pull request Dec 30, 2022
@caveman99
Copy link
Sponsor Member Author

Every time we call this, same leak, 360 bytes...
[NodeInfoModule] Thread NodeInfoModule leaked heap 90348 -> 89988 (-360)

Also this, but only sometimes, still same amount of bytes when it happens
[RadioIf] Thread RadioIf leaked heap 88224 -> 87900 (-324)

@caveman99
Copy link
Sponsor Member Author

Also this, but only sometimes, still same amount of bytes when it happens [RadioIf] Thread RadioIf leaked heap 88224 -> 87900 (-324)

the 324 may be harmless... Router frees that up again, seems to be a packet struct...

??:??:?? 16 [RadioIf] (bw=250, sf=11, cr=4/8) packet symLen=8 ms, payloadSize=27, time 690 ms
??:??:?? 16 [RadioIf] Lora RX (id=0x7cf711c6 fr=0x24 to=0xff, WantAck=0, HopLim=2 Ch=0x8 encrypted rxSNR=10.5 rxRSSI=1.84221)
??:??:?? 16 [RadioIf] AirTime - Packet received : 690ms
??:??:?? 16 [RadioIf] --- --- Thread RadioIf leaked heap 120040 -> 119716 (-324)
??:??:?? 16 [Router] Rx someone rebroadcasting for us (id=0x7cf711c6 fr=0x24 to=0xff, WantAck=0, HopLim=2 Ch=0x8 encrypted rxSNR=10.5 rxRSSI=1.84221)
??:??:?? 16 [Router] didn't find pending packet
??:??:?? 16 [Router] Found existing packet record for fr=0x25d63124,to=0xffffffff,id=0x7cf711c6
??:??:?? 16 [Router] Found existing packet record for fr=0x25d63124,to=0xffffffff,id=0x7cf711c6
??:??:?? 16 [Router] Add packet record (id=0x7cf711c6 fr=0x24 to=0xff, WantAck=0, HopLim=2 Ch=0x8 encrypted rxSNR=10.5 rxRSSI=1.84221)
??:??:?? 16 [Router] Ignoring incoming msg, because we've already seen it (id=0x7cf711c6 fr=0x24 to=0xff, WantAck=0, HopLim=2 Ch=0x8 encrypted rxSNR=10.5 rxRSSI=1.84221)
??:??:?? 16 [Router] Incoming message was filtered 0x25d63124
??:??:?? 16 [Router] +++ +++ Thread Router freed heap 119716 -> 120040 (324)

thebentern added a commit to meshtastic/artifacts that referenced this pull request Dec 30, 2022
thebentern added a commit to meshtastic/artifacts that referenced this pull request Dec 30, 2022
thebentern added a commit to meshtastic/artifacts that referenced this pull request Dec 30, 2022
@caveman99 caveman99 merged commit 9a04aaa into develop Dec 30, 2022
@caveman99 caveman99 deleted the nice-threads branch December 30, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants