-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threshold based smart position broadcasts #2388
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Mar 26, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Mar 26, 2023
caveman99
approved these changes
Mar 27, 2023
caveman99
force-pushed
the
smart-broadcast-overhaul
branch
from
March 27, 2023 09:28
be1d9e6
to
cadd64a
Compare
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Mar 27, 2023
garthvh
approved these changes
Mar 27, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Mar 27, 2023
GUVWAF
approved these changes
Mar 27, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Mar 27, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Mar 27, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Mar 27, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the new protobufs, smart broadcast positioning will honor two position config properties:
Broadcast_smart_minimum_distance (default of 100) is the minimum distance traveled in meters before we consider sending our position.
Broadcast_smart_minimum_interval_secs (default of 30) is the minimum seconds after the last sent position before we consider sending our position again.
Position_broadcast_secs is still honored as the interval for regular broadcasting of positions, so users likely want this to be a longer interval to avoid wasted packets while a node is static.
Tracker role changes: